Skip to content

Commit 1b9bd69

Browse files
yyx990803yyx990803
committed
perf: v-for fragments do not need to track dynamicChildren
1 parent 71f3826 commit 1b9bd69

File tree

4 files changed

+19
-18
lines changed

4 files changed

+19
-18
lines changed

‎packages/compiler-core/__tests__/__snapshots__/compile.spec.ts.snap

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ return function render() {
1515
(_openBlock(), ok
1616
? _createBlock(\\"div\\", { key: 0 }, \\"yes\\")
1717
: _createBlock(_Fragment, { key: 1 }, [\\"no\\"])),
18-
(_openBlock(), _createBlock(_Fragment, null, _renderList(list, (value, index) => {
18+
(_openBlock(false), _createBlock(_Fragment, null, _renderList(list, (value, index) => {
1919
return (_openBlock(), _createBlock(\\"div\\", null, [
2020
_createVNode(\\"span\\", null, _toString(value + index), 1 /* TEXT */)
2121
]))
@@ -38,7 +38,7 @@ return function render() {
3838
(openBlock(), (_ctx.ok)
3939
? createBlock(\\"div\\", { key: 0 }, \\"yes\\")
4040
: createBlock(Fragment, { key: 1 }, [\\"no\\"])),
41-
(openBlock(), createBlock(Fragment, null, renderList(_ctx.list, (value, index) => {
41+
(openBlock(false), createBlock(Fragment, null, renderList(_ctx.list, (value, index) => {
4242
return (openBlock(), createBlock(\\"div\\", null, [
4343
createVNode(\\"span\\", null, toString(value + index), 1 /* TEXT */)
4444
]))
@@ -60,7 +60,7 @@ export default function render() {
6060
(openBlock(), (_ctx.ok)
6161
? createBlock(\\"div\\", { key: 0 }, \\"yes\\")
6262
: createBlock(Fragment, { key: 1 }, [\\"no\\"])),
63-
(openBlock(), createBlock(Fragment, null, renderList(_ctx.list, (value, index) => {
63+
(openBlock(false), createBlock(Fragment, null, renderList(_ctx.list, (value, index) => {
6464
return (openBlock(), createBlock(\\"div\\", null, [
6565
createVNode(\\"span\\", null, toString(value + index), 1 /* TEXT */)
6666
]))

‎packages/compiler-core/__tests__/transforms/__snapshots__/hoistStatic.spec.ts.snap

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ return function render() {
227227
const { renderList: _renderList, openBlock: _openBlock, createBlock: _createBlock, Fragment: _Fragment, toString: _toString, createVNode: _createVNode } = _Vue
228228
229229
return (_openBlock(), _createBlock(\\"div\\", null, [
230-
(_openBlock(), _createBlock(_Fragment, null, _renderList(_ctx.list, (o) => {
230+
(_openBlock(false), _createBlock(_Fragment, null, _renderList(_ctx.list, (o) => {
231231
return (_openBlock(), _createBlock(\\"p\\", null, [
232232
_createVNode(\\"span\\", null, _toString(o + 'foo'), 1 /* TEXT */)
233233
]))
@@ -262,7 +262,7 @@ return function render() {
262262
const { renderList: _renderList, openBlock: _openBlock, createBlock: _createBlock, Fragment: _Fragment, toString: _toString, createVNode: _createVNode } = _Vue
263263
264264
return (_openBlock(), _createBlock(\\"div\\", null, [
265-
(_openBlock(), _createBlock(_Fragment, null, _renderList(_ctx.list, (o) => {
265+
(_openBlock(false), _createBlock(_Fragment, null, _renderList(_ctx.list, (o) => {
266266
return (_openBlock(), _createBlock(\\"p\\", null, [
267267
_createVNode(\\"span\\", null, _toString(o), 1 /* TEXT */)
268268
]))
@@ -354,7 +354,7 @@ return function render() {
354354
const { renderList: _renderList, openBlock: _openBlock, createBlock: _createBlock, Fragment: _Fragment, createVNode: _createVNode } = _Vue
355355
356356
return (_openBlock(), _createBlock(\\"div\\", null, [
357-
(_openBlock(), _createBlock(_Fragment, null, _renderList(list, (i) => {
357+
(_openBlock(false), _createBlock(_Fragment, null, _renderList(list, (i) => {
358358
return (_openBlock(), _createBlock(\\"div\\", _hoisted_1, [
359359
_hoisted_2
360360
]))

‎packages/compiler-core/__tests__/transforms/__snapshots__/vFor.spec.ts.snap

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ return function render() {
77
with (this) {
88
const { renderList: _renderList, openBlock: _openBlock, createBlock: _createBlock, Fragment: _Fragment, createVNode: _createVNode } = _Vue
99
10-
return (_openBlock(), _createBlock(_Fragment, null, _renderList(items, (item) => {
10+
return (_openBlock(false), _createBlock(_Fragment, null, _renderList(items, (item) => {
1111
return (_openBlock(), _createBlock(\\"span\\"))
1212
}), 128 /* UNKEYED_FRAGMENT */))
1313
}
@@ -21,7 +21,7 @@ return function render() {
2121
with (this) {
2222
const { renderList: _renderList, openBlock: _openBlock, createBlock: _createBlock, Fragment: _Fragment, createVNode: _createVNode } = _Vue
2323
24-
return (_openBlock(), _createBlock(_Fragment, null, _renderList(items, (item) => {
24+
return (_openBlock(false), _createBlock(_Fragment, null, _renderList(items, (item) => {
2525
return (_openBlock(), _createBlock(_Fragment, { key: item }, [
2626
\\"hello\\",
2727
_createVNode(\\"span\\")
@@ -38,7 +38,7 @@ return function render() {
3838
with (this) {
3939
const { renderList: _renderList, openBlock: _openBlock, createBlock: _createBlock, Fragment: _Fragment, createVNode: _createVNode } = _Vue
4040
41-
return (_openBlock(), _createBlock(_Fragment, null, _renderList(items, (item) => {
41+
return (_openBlock(false), _createBlock(_Fragment, null, _renderList(items, (item) => {
4242
return (_openBlock(), _createBlock(\\"span\\", { key: item }))
4343
}), 64 /* KEYED_FRAGMENT */))
4444
}
@@ -52,7 +52,7 @@ return function render() {
5252
with (this) {
5353
const { renderList: _renderList, openBlock: _openBlock, createBlock: _createBlock, Fragment: _Fragment, createVNode: _createVNode } = _Vue
5454
55-
return (_openBlock(), _createBlock(_Fragment, null, _renderList(items, (item, __, index) => {
55+
return (_openBlock(false), _createBlock(_Fragment, null, _renderList(items, (item, __, index) => {
5656
return (_openBlock(), _createBlock(\\"span\\"))
5757
}), 128 /* UNKEYED_FRAGMENT */))
5858
}
@@ -66,7 +66,7 @@ return function render() {
6666
with (this) {
6767
const { renderList: _renderList, openBlock: _openBlock, createBlock: _createBlock, Fragment: _Fragment, createVNode: _createVNode } = _Vue
6868
69-
return (_openBlock(), _createBlock(_Fragment, null, _renderList(items, (_, __, index) => {
69+
return (_openBlock(false), _createBlock(_Fragment, null, _renderList(items, (_, __, index) => {
7070
return (_openBlock(), _createBlock(\\"span\\"))
7171
}), 128 /* UNKEYED_FRAGMENT */))
7272
}
@@ -80,7 +80,7 @@ return function render() {
8080
with (this) {
8181
const { renderList: _renderList, openBlock: _openBlock, createBlock: _createBlock, Fragment: _Fragment, createVNode: _createVNode } = _Vue
8282
83-
return (_openBlock(), _createBlock(_Fragment, null, _renderList(items, (_, key, index) => {
83+
return (_openBlock(false), _createBlock(_Fragment, null, _renderList(items, (_, key, index) => {
8484
return (_openBlock(), _createBlock(\\"span\\"))
8585
}), 128 /* UNKEYED_FRAGMENT */))
8686
}
@@ -94,7 +94,7 @@ return function render() {
9494
with (this) {
9595
const { renderList: _renderList, openBlock: _openBlock, createBlock: _createBlock, Fragment: _Fragment, createVNode: _createVNode } = _Vue
9696
97-
return (_openBlock(), _createBlock(_Fragment, null, _renderList(items, (item) => {
97+
return (_openBlock(false), _createBlock(_Fragment, null, _renderList(items, (item) => {
9898
return (_openBlock(), _createBlock(_Fragment, null, [
9999
\\"hello\\",
100100
_createVNode(\\"span\\")
@@ -111,7 +111,7 @@ return function render() {
111111
with (this) {
112112
const { renderList: _renderList, openBlock: _openBlock, createBlock: _createBlock, Fragment: _Fragment, renderSlot: _renderSlot } = _Vue
113113
114-
return (_openBlock(), _createBlock(_Fragment, null, _renderList(items, (item) => {
114+
return (_openBlock(false), _createBlock(_Fragment, null, _renderList(items, (item) => {
115115
return _renderSlot($slots, \\"default\\")
116116
}), 128 /* UNKEYED_FRAGMENT */))
117117
}
@@ -125,7 +125,7 @@ return function render() {
125125
with (this) {
126126
const { renderList: _renderList, openBlock: _openBlock, createBlock: _createBlock, Fragment: _Fragment, renderSlot: _renderSlot } = _Vue
127127
128-
return (_openBlock(), _createBlock(_Fragment, null, _renderList(items, (item) => {
128+
return (_openBlock(false), _createBlock(_Fragment, null, _renderList(items, (item) => {
129129
return _renderSlot($slots, \\"default\\")
130130
}), 128 /* UNKEYED_FRAGMENT */))
131131
}
@@ -141,7 +141,7 @@ return function render() {
141141
142142
const _directive_foo = _resolveDirective(\\"foo\\")
143143
144-
return (_openBlock(), _createBlock(_Fragment, null, _renderList(list, (i) => {
144+
return (_openBlock(false), _createBlock(_Fragment, null, _renderList(list, (i) => {
145145
return (_openBlock(), _withDirectives(_createBlock(\\"div\\", null, null, 32 /* NEED_PATCH */), [
146146
[_directive_foo]
147147
]))
@@ -173,7 +173,7 @@ return function render() {
173173
with (this) {
174174
const { renderList: _renderList, openBlock: _openBlock, createBlock: _createBlock, Fragment: _Fragment, createVNode: _createVNode } = _Vue
175175
176-
return (_openBlock(), _createBlock(_Fragment, null, _renderList(items, (item, key, index) => {
176+
return (_openBlock(false), _createBlock(_Fragment, null, _renderList(items, (item, key, index) => {
177177
return (_openBlock(), _createBlock(\\"span\\"))
178178
}), 128 /* UNKEYED_FRAGMENT */))
179179
}

‎packages/compiler-core/src/transforms/vFor.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,8 @@ export const transformFor = createStructuralDirectiveTransform(
7171
? PatchFlags.KEYED_FRAGMENT
7272
: PatchFlags.UNKEYED_FRAGMENT
7373
const codegenNode = createSequenceExpression([
74-
createCallExpression(helper(OPEN_BLOCK)),
74+
// fragment blocks disable tracking since they always diff their children
75+
createCallExpression(helper(OPEN_BLOCK), [`false`]),
7576
createCallExpression(helper(CREATE_BLOCK), [
7677
helper(FRAGMENT),
7778
`null`,

0 commit comments

Comments
 (0)