Skip to content

TransactionPayloadEventDataDeserializer may lost the CompatibilityMode settings from parent EventDeserializer #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZzzCrazyPig opened this issue Oct 25, 2023 · 1 comment

Comments

@ZzzCrazyPig
Copy link

ZzzCrazyPig commented Oct 25, 2023

According to the implement code of TransactionPayloadEventDataDeserializer:

// Read and store events from decompressed byte array into input stream
        ArrayList<Event> decompressedEvents = new ArrayList<>();
        //  may lost the CompatibilityMode settings from parent EventDeserializer
        EventDeserializer transactionPayloadEventDeserializer = new EventDeserializer();
        ByteArrayInputStream destinationInputStream = new ByteArrayInputStream(dst);

        Event internalEvent = transactionPayloadEventDeserializer.nextEvent(destinationInputStream);
        while(internalEvent != null) {
            decompressedEvents.add(internalEvent);
            internalEvent = transactionPayloadEventDeserializer.nextEvent(destinationInputStream);
        }

we are sure that it create the default EventDeserializer to deserialize internal uncompressed event , it will lost the CompatibilityMode settings from parent EventDeserializer

@ZzzCrazyPig
Copy link
Author

@osheroff Please confirm ?

ZzzCrazyPig added a commit to ZzzCrazyPig/mysql-binlog-connector-java that referenced this issue Oct 30, 2023
ZzzCrazyPig added a commit to ZzzCrazyPig/mysql-binlog-connector-java that referenced this issue Dec 16, 2023
@ZzzCrazyPig ZzzCrazyPig changed the title TransactionPayloadEventDataDeserializer not supported custom EventDeserializer TransactionPayloadEventDataDeserializer may lost the CompatibilityMode settings from parent EventDeserializer Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant