Skip to content

Commit 69eb60f

Browse files
DavidS-ovmactions-user
authored andcommitted
Update change message to be less redundant and verbose (#1506)
This is based on Dylan's feedback after the first round. Fixes ENG-363 GitOrigin-RevId: b7cb44524d46361d72f978e47761a9e3b5e1a1f0
1 parent 1661e5c commit 69eb60f

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

sdp-go/util.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ func RenderItemDiff(gun string, before, after map[string]any, changeData, rawDat
163163
slices.Sort(v)
164164

165165
if len(v) > 0 {
166-
para = append(para, fmt.Sprintf("# → 🔁 The '%v' attribute has changed %d times in the last 30 days. The previous values were %v.", k, len(v), v))
166+
para = append(para, fmt.Sprintf("# → 🔁 This attribute has changed %d times in the last 30 days.\n# The previous values were %v.", len(v), v))
167167
}
168168
}
169169
}

sdp-go/util_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ func TestItemDiffParagraphRendering(t *testing.T) {
143143
Value: "user",
144144
},
145145
},
146-
ExpectedDiffParagraph: "- name.last: user\n+ name.last: updated\n# → 🔁 The 'testGun.name.last' attribute has changed 1 times in the last 30 days. The previous values were [user].",
146+
ExpectedDiffParagraph: "- name.last: user\n+ name.last: updated\n# → 🔁 This attribute has changed 1 times in the last 30 days.\n# The previous values were [user].",
147147
},
148148
{
149149
Name: "with stats, no changes",

0 commit comments

Comments
 (0)