Merge pull request pubnub#34 from davidnub/feature/CE-4217-presence-heartbeat

fix default presence timeout to undefined

Author: raipubnub

src/core/components/config.js

@@ -249,8 +249,6 @@ export default class {
       );
     }
 
-    this.setHeartbeatInterval(this._presenceTimeout / 2 - 1);
-
     return this;
   }
 

test/integration/components/reconnection_manager.test.js

@@ -27,6 +27,7 @@ describe('#components/reconnection_manger', () => {
       subscribeKey: 'mySubKey',
       publishKey: 'myPublishKey',
       uuid: 'myUUID',
+      heartbeatInterval: 149,
     });
     clock = sinon.useFakeTimers();
   });

test/integration/components/subscription_manager.test.js

@@ -28,20 +28,23 @@ describe('#components/subscription_manager', () => {
       publishKey: 'myPublishKey',
       uuid: 'myUUID',
       autoNetworkDetection: false,
+      heartbeatInterval: 149,
     });
     pubnubWithPassingHeartbeats = new PubNub({
       subscribeKey: 'mySubKey',
       publishKey: 'myPublishKey',
       uuid: 'myUUID',
       announceSuccessfulHeartbeats: true,
       autoNetworkDetection: false,
+      heartbeatInterval: 149,
     });
     pubnubWithLimitedQueue = new PubNub({
       subscribeKey: 'mySubKey',
       publishKey: 'myPublishKey',
       uuid: 'myUUID',
       requestMessageCountThreshold: 1,
       autoNetworkDetection: false,
+      heartbeatInterval: 149,
     });
   });
 
@@ -554,7 +557,7 @@ describe('#components/subscription_manager', () => {
     }, 250);
   });
 
-  it('supports deduping on shawllow queue', (done) => {
+  it('supports deduping on shallow queue', (done) => {
     pubnub._config.dedupeOnSubscribe = true;
     pubnub._config.maximumCacheSize = 1;
     let messageCount = 0;

test/unit/common.test.js

@@ -6,6 +6,11 @@ import PubNub from '../../src/node/index';
 import CryptoJS from '../../src/core/components/cryptography/hmac-sha256';
 
 describe('#core / mounting point', () => {
+  it('should have default heartbeat interval undefined', () => {
+    let pn = new PubNub({});
+    assert(pn._config.getHeartbeatInterval() === undefined);
+  });
+
   it('supports UUID generation', () => {
     assert.equal(lilUUID.isUUID(PubNub.generateUUID()), true);
   });