Merge pull request frappe#6498 from ElasticRun/series-key

fix: refactor primary key in series patch

Author: sagarvora

frappe/patches.txt

@@ -229,9 +229,9 @@ frappe.patches.v10_0.modify_naming_series_table
 frappe.patches.v10_0.enhance_security
 frappe.patches.v11_0.multiple_references_in_events
 frappe.patches.v11_0.set_allow_self_approval_in_workflow
-execute:frappe.db.sql('ALTER table `tabSeries` ADD PRIMARY KEY IF NOT EXISTS (name)')
 frappe.patches.v11_0.remove_skip_for_doctype
 frappe.patches.v11_0.migrate_report_settings_for_new_listview
 frappe.patches.v11_0.delete_all_prepared_reports
 frappe.patches.v11_0.fix_order_by_in_reports_json
 execute:frappe.delete_doc('Page', 'applications', ignore_missing=True)
+frappe.patches.v12_0.set_primary_key_in_series

frappe/patches/v12_0/set_primary_key_in_series.py

@@ -0,0 +1,21 @@
+import frappe
+
+def execute():
+    #if current = 0, simply delete the key as it'll be recreated on first entry
+    frappe.db.sql('delete from `tabSeries` where current = 0')
+    duplicate_keys = frappe.db.sql('''
+        SELECT name, max(current) as current
+        from
+            `tabSeries`
+        group by
+            name
+        having count(name) > 1
+    ''', as_dict=True)
+    for row in duplicate_keys:
+        frappe.db.sql('delete from `tabSeries` where name = %(key)s', {
+            'key': row.name
+        })
+        if row.current:
+            frappe.db.sql('insert into `tabSeries`(`name`, `current`) values (%(name)s, %(current)s)', row)
+    frappe.db.commit()
+    frappe.db.sql('ALTER table `tabSeries` ADD PRIMARY KEY IF NOT EXISTS (name)')