Fix: only set state when prop changes (APSL#209)

Swordsman-Inaction · alvaromb · commit aa8d623c7ee9 · 2018-01-12T15:37:29.000+01:00
diff --git a/lib/KeyboardAwareHOC.js b/lib/KeyboardAwareHOC.js
@@ -114,11 +114,13 @@ function listenToKeyboardEvents(ScrollableComponent: React$Component) {
     }
 
     componentWillReceiveProps(nextProps: KeyboardAwareHOCProps) {
-      const keyboardSpace: number = nextProps.viewIsInsideTabBar
-        ? _KAM_DEFAULT_TAB_BAR_HEIGHT
-        : 0
-      if (this.state.keyboardSpace !== keyboardSpace) {
-        this.setState({ keyboardSpace })
+      if (nextProps.viewIsInsideTabBar !== this.props.viewIsInsideTabBar) {
+        const keyboardSpace: number = nextProps.viewIsInsideTabBar
+          ? _KAM_DEFAULT_TAB_BAR_HEIGHT
+          : 0
+        if (this.state.keyboardSpace !== keyboardSpace) {
+          this.setState({ keyboardSpace })
+        }
       }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -114,11 +114,13 @@ function listenToKeyboardEvents(ScrollableComponent: React$Component) {`
`114`	`114`	`}`
`115`	`115`
`116`	`116`	`componentWillReceiveProps(nextProps: KeyboardAwareHOCProps) {`
`117`		`- const keyboardSpace: number = nextProps.viewIsInsideTabBar`
`118`		`- ? _KAM_DEFAULT_TAB_BAR_HEIGHT`
`119`		`- : 0`
`120`		`- if (this.state.keyboardSpace !== keyboardSpace) {`
`121`		`- this.setState({ keyboardSpace })`
	`117`	`+ if (nextProps.viewIsInsideTabBar !== this.props.viewIsInsideTabBar) {`
	`118`	`+ const keyboardSpace: number = nextProps.viewIsInsideTabBar`
	`119`	`+ ? _KAM_DEFAULT_TAB_BAR_HEIGHT`
	`120`	`+ : 0`
	`121`	`+ if (this.state.keyboardSpace !== keyboardSpace) {`
	`122`	`+ this.setState({ keyboardSpace })`
	`123`	`+ }`
`122`	`124`	`}`
`123`	`125`	`}`
`124`	`126`