Skip to content

Commit 071bf54

Browse files
committed
Revert "Add $(LDFLAGS) when linking binary modules"
'LDFLAGS is "the flags that the perl binary itself will be linked with", in particular that means the flags are suitable for an executable instead of a loadable object. The latter is done using LDDLFLAGS which largely but not fully overlaps with LDFLAGS. Also, this has absolutely nothing to do with the LDFLAGS environment variable, it's the ldflags configuration variable.' This reverts commit f1e7b9a.
1 parent a44d189 commit 071bf54

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lib/ExtUtils/MM_Unix.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1092,7 +1092,7 @@ sub xs_make_dynamic_lib {
10921092
}
10931093

10941094
push @m, sprintf <<'MAKE', $ld_run_path_shell, $ldrun, $dlsyms_arg, $ldfrom, $self->xs_obj_opt('$@'), $libs, $exportlist;
1095-
%s$(LD) %s $(LDDLFLAGS) %s %s $(LDFLAGS) $(OTHERLDFLAGS) %s $(MYEXTLIB) \
1095+
%s$(LD) %s $(LDDLFLAGS) %s %s $(OTHERLDFLAGS) %s $(MYEXTLIB) \
10961096
$(PERL_ARCHIVE) %s $(PERL_ARCHIVE_AFTER) %s \
10971097
$(INST_DYNAMIC_FIX)
10981098
$(CHMOD) $(PERM_RWX) $@

0 commit comments

Comments
 (0)