Skip to content

Feedback related to Quadrature Encoder #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rkompass opened this issue Aug 25, 2023 · 1 comment
Closed

Feedback related to Quadrature Encoder #112

rkompass opened this issue Aug 25, 2023 · 1 comment

Comments

@rkompass
Copy link

Hi Peter,

just to give a feedback now:
I checked your Encoder code and it looks fine. After introducing the if (x := pin_x()) != self._x: the flawed behaviour that I once mentioned (a year ago) should be gone.
I tried to point you to the flaw then, without success. Later I saw that you had corrected the code without giving credit to my discussion and was disappointed. Later again I saw you got the point by another issue mentioned later. :-)

@peterhinch
Copy link
Owner

Apologies. I think it took me a while to grasp that the problem arises if further edges occur during the latency period between the first edge and the ISR actually running. Encoders are much more tricky than people realise...

I have added a credit for your contribution to encoder.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants