Skip to content

Commit 01e3162

Browse files
authored
Small code improvements
Recommended by @withshubh's DeepSource bot. Thanks!
1 parent 3c7c46c commit 01e3162

File tree

3 files changed

+2
-8
lines changed

3 files changed

+2
-8
lines changed

helium/_impl/__init__.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1044,14 +1044,10 @@ def get_element_types(self):
10441044
raise NotImplementedError()
10451045

10461046
class ClickableText(CompositeElement):
1047-
def __init__(self, driver, text, **kwargs):
1048-
super(ClickableText, self).__init__(driver, text, **kwargs)
10491047
def get_element_types(self):
10501048
return [ButtonImpl, TextImpl, ImageImpl]
10511049

10521050
class TextFieldImpl(CompositeElement):
1053-
def __init__(self, driver, label=None, **kwargs):
1054-
super(TextFieldImpl, self).__init__(driver, label, **kwargs)
10551051
def get_element_types(self):
10561052
return [
10571053
StandardTextFieldWithPlaceholder, StandardTextFieldWithLabel,
@@ -1112,8 +1108,6 @@ def get_xpath(self):
11121108
return "//input[@type='file']"
11131109

11141110
class ComboBoxImpl(CompositeElement):
1115-
def __init__(self, driver, label=None, **kwargs):
1116-
super(ComboBoxImpl, self).__init__(driver, label, **kwargs)
11171111
def get_element_types(self):
11181112
return [ComboBoxIdentifiedByDisplayedValue, ComboBoxIdentifiedByLabel]
11191113
def is_editable(self):

tests/api/test_gui_elements.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ def test_link_empty_href(self):
256256
# ListItem tests:
257257
def test_list_item_no_text(self):
258258
all_list_items = find_all(ListItem(below="HTML Unordered List"))
259-
texts = set(list_item.web_element.text for list_item in all_list_items)
259+
texts = {list_item.web_element.text for list_item in all_list_items}
260260
self.assertEqual({'ListItem 1', 'ListItem 2'}, texts)
261261

262262
# Image tests:

tests/api/test_rightclick.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from helium import click, hover, rightclick
1+
from helium import click, rightclick
22
from tests.api import BrowserAT
33

44
class RightclickTest(BrowserAT):

0 commit comments

Comments
 (0)