Adjust various testData to remove/charAt transformation

Author: dzharkov

compiler/testData/codegen/box/builtinStubMethods/ListWithAllImplementations.kt

@@ -14,15 +14,15 @@ class MyList<T>(val v: T): List<T> {
     override fun equals(other: Any?): Boolean = false
 
     public fun add(e: T): Boolean = true
-    public fun remove(o: Any?): Boolean = true
+    public fun remove(o: T): Boolean = true
     public fun addAll(c: Collection<T>): Boolean = true
     public fun addAll(index: Int, c: Collection<T>): Boolean = true
     public fun removeAll(c: Collection<Any?>): Boolean = true
     public fun retainAll(c: Collection<Any?>): Boolean = true
     public fun clear() {}
     public fun set(index: Int, element: T): T = element
     public fun add(index: Int, element: T) {}
-    public fun remove(index: Int): T = v
+    public fun removeAt(index: Int): T = v
 }
 
 fun box(): String {

compiler/testData/codegen/box/builtinStubMethods/ListWithAllInheritedImplementations.kt

@@ -1,14 +1,14 @@
 open class Super<T>(val v: T) {
     public fun add(e: T): Boolean = true
-    public fun remove(o: Any?): Boolean = true
+    public fun remove(o: T): Boolean = true
     public fun addAll(c: Collection<T>): Boolean = true
     public fun addAll(index: Int, c: Collection<T>): Boolean = true
     public fun removeAll(c: Collection<Any?>): Boolean = true
     public fun retainAll(c: Collection<Any?>): Boolean = true
     public fun clear() {}
     public fun set(index: Int, element: T): T = element
     public fun add(index: Int, element: T) {}
-    public fun remove(index: Int): T = v
+    public fun removeAt(index: Int): T = v
 }
 
 class MyList<T>(v: T): Super<T>(v), List<T> {

compiler/testData/codegen/box/builtinStubMethods/extendJavaCollections/arrayList.kt

@@ -17,7 +17,7 @@ fun box(): String {
     a.add("")
     a.set(0, "")
     a.add(0, "")
-    a.remove(0)
+    a.removeAt(0)
     a.remove("")
 
     return "OK"

compiler/testData/codegen/box/builtinStubMethods/inheritedImplementations.kt

@@ -1,6 +1,6 @@
 open class SetStringImpl {
     fun add(s: String): Boolean = false
-    fun remove(o: Any?): Boolean = false
+    fun remove(o: String): Boolean = false
     fun clear(): Unit {}
 }
 

compiler/testData/codegen/box/builtinsProperties/collectionImpl.kt

@@ -22,7 +22,7 @@ class A1 : MutableCollection<String> {
         throw UnsupportedOperationException()
     }
 
-    override fun remove(o: Any?): Boolean {
+    override fun remove(o: String): Boolean {
         throw UnsupportedOperationException()
     }
 

compiler/testData/codegen/box/extensionFunctions/simple.kt

@@ -1,4 +1,4 @@
-fun StringBuilder.first() = this.charAt(0)
+fun StringBuilder.first() = this.get(0)
 
 fun foo() = StringBuilder("foo").first()
 

compiler/testData/codegen/box/extensionFunctions/whenFail.kt

@@ -1,6 +1,6 @@
 fun StringBuilder.takeFirst(): Char {
   if (this.length() == 0) return 0.toChar()
-  val c = this.charAt(0)
+  val c = this.get(0)
   this.deleteCharAt(0)
   return c
 }

compiler/testData/codegen/box/intrinsics/infixCall.kt

@@ -1,5 +1,5 @@
 fun box(): String {
-    val o = "OK" charAt 0
+    val o = "OK" get 0
     val array = CharArray(2)
     array[1] = 'K'
     val k = array get 1

compiler/testData/codegen/box/strings/kt5956.kt

@@ -1,7 +1,7 @@
 // KT-5956 java.lang.AbstractMethodError: test.Thing.subSequence(II)Ljava/lang/CharSequence
 
 class Thing(val delegate: CharSequence) : CharSequence {
-    override fun charAt(index: Int): Char {
+    override fun get(index: Int): Char {
         throw UnsupportedOperationException()
     }
     override fun length(): Int = 0

compiler/testData/codegen/boxWithJava/collections/mutableList/mutableList.kt

@@ -3,7 +3,7 @@ open class KList<E> : MutableList<E> {
         throw UnsupportedOperationException()
     }
 
-    override fun remove(o: Any?): Boolean {
+    override fun remove(o: E): Boolean {
         throw UnsupportedOperationException()
     }
 
@@ -35,7 +35,7 @@ open class KList<E> : MutableList<E> {
         throw UnsupportedOperationException()
     }
 
-    override fun remove(index: Int): E {
+    override fun removeAt(index: Int): E {
         throw UnsupportedOperationException()
     }
 

compiler/testData/codegen/boxWithJava/collections/strList/strList.kt

@@ -29,7 +29,7 @@ open class KList : MutableList<String> {
         throw UnsupportedOperationException()
     }
 
-    override fun remove(o: Any?): Boolean {
+    override fun remove(o: String): Boolean {
         throw UnsupportedOperationException()
     }
 
@@ -61,7 +61,7 @@ open class KList : MutableList<String> {
         throw UnsupportedOperationException()
     }
 
-    override fun remove(index: Int): String {
+    override fun removeAt(index: Int): String {
         throw UnsupportedOperationException()
     }
 

compiler/testData/diagnostics/tests/library/Collections.kt

@@ -26,7 +26,7 @@ fun <T> testMutableCollection(c: MutableCollection<T>, t: T) {
 
     val <!UNUSED_VARIABLE!>mutableIterator<!>: MutableIterator<T> = c.iterator()
     c.add(t)
-    c.remove(1)
+    c.remove(<!UNCHECKED_CAST!>1 as T<!>)
     c.addAll(c)
     c.removeAll(c)
     c.retainAll(c)
@@ -52,7 +52,7 @@ fun <T> testList(l: List<T>, <!UNUSED_PARAMETER!>t<!>: T) {
 fun <T> testMutableList(l: MutableList<T>, t: T) {
     val <!UNUSED_VARIABLE!>value<!>: T = l.set(1, t)
     l.add(1, t)
-    l.remove(1)
+    l.removeAt(1)
     val <!UNUSED_VARIABLE!>mutableListIterator<!>: MutableListIterator<T> = l.listIterator()
     val <!UNUSED_VARIABLE!>mutableListIterator1<!>: MutableListIterator<T> = l.listIterator(1)
     val <!UNUSED_VARIABLE!>mutableList<!>: MutableList<T> = l.subList(1, 2)
@@ -84,7 +84,7 @@ fun <T> testMutableSet(s: MutableSet<T>, t: T) {
 
     val <!UNUSED_VARIABLE!>mutableIterator<!>: MutableIterator<T> = s.iterator()
     s.add(t)
-    s.remove(1)
+    s.remove(<!UNCHECKED_CAST!>1 as T<!>)
     s.addAll(s)
     s.removeAll(s)
     s.retainAll(s)

compiler/testData/diagnostics/tests/regressions/DoubleDefine.kt

@@ -3,7 +3,7 @@ import java.util.*
 import java.io.*
 
 fun takeFirst(expr: StringBuilder): Char {
-  val c = expr.charAt(0)
+  val c = expr.get(0)
   expr.deleteCharAt(0)
   return c
 }
@@ -31,7 +31,7 @@ fun evaluateAdd(expr: StringBuilder, numbers: ArrayList<Int>): Int {
 fun evaluate(expr: StringBuilder, numbers: ArrayList<Int>): Int {
   val lhs = evaluateAdd(expr, numbers)
   if (expr.length() > 0) {
-    val <!UNUSED_VARIABLE!>c<!> = expr.charAt(0)
+    val <!UNUSED_VARIABLE!>c<!> = expr.get(0)
     expr.deleteCharAt(0)
   }
   return lhs

compiler/testData/diagnostics/tests/smartCasts/safecalls/extensionCall.kt

@@ -2,5 +2,5 @@ fun String.bar(s: String) = s
 
 fun foo(s: String?) {
     s?.bar(<!DEBUG_INFO_SMARTCAST!>s<!>)
-    s?.charAt(<!DEBUG_INFO_SMARTCAST!>s<!>.length())
+    s?.get(<!DEBUG_INFO_SMARTCAST!>s<!>.length())
 }

compiler/tests/org/jetbrains/kotlin/codegen/PackageGenTest.java

@@ -384,7 +384,7 @@ public void testSubstituteJavaMethodTypeParameters() throws Exception {
     }
 
     public void testCallMethodDeclaredInSuperclass() throws Exception {
-        loadText("fun foo(sb: StringBuilder) = sb.charAt(0)");
+        loadText("fun foo(sb: StringBuilder) = sb.get(0)");
         Method main = generateFunction();
         StringBuilder sb = new StringBuilder("x");
         assertEquals('x', ((Character) main.invoke(null, sb)).charValue());

idea/idea-completion/testData/basic/java/boldOrGrayed/ImmediateMembersForPlatformType.kt

@@ -11,4 +11,4 @@ class C {
 // EXIST: { itemText: "extFunForString", attributes: "bold" }
 // EXIST: { itemText: "extFunForAny", attributes: "" }
 // EXIST: { itemText: "extFunForStringNullable", attributes: "bold" }
-// EXIST: { itemText: "charAt", attributes: "" }
+// EXIST: { itemText: "get", attributes: "" }

idea/testData/checker/regression/DoubleDefine.kt

@@ -3,7 +3,7 @@ import java.util.*
 import java.io.*
 
 fun takeFirst(expr: StringBuilder): Char {
-  val c = expr.charAt(0)
+  val c = expr.get(0)
   expr.deleteCharAt(0)
   return c
 }
@@ -31,7 +31,7 @@ fun evaluateAdd(expr: StringBuilder, numbers: ArrayList<Int>): Int {
 fun evaluate(expr: StringBuilder, numbers: ArrayList<Int>): Int {
   val lhs = evaluateAdd(expr, numbers)
   if (expr.length() > 0) {
-    val <warning>c</warning> = expr.charAt(0)
+    val <warning>c</warning> = expr.get(0)
     expr.deleteCharAt(0)
   }
   return lhs

js/js.translator/testData/java/arrayList/cases/misc.kt

@@ -11,7 +11,7 @@ fun box(): Boolean {
 
     // test addAt
     list.add(0, 400)
-    list.remove(0);
+    list.removeAt(0);
     list.add(1, 500)
     // test contains, addAll
     if (!list.contains(500) || list.contains(600) || list.addAll(ArrayList<Int>())) {

js/js.translator/testData/java/arrayList/cases/remove.kt

@@ -8,7 +8,7 @@ fun box(): Boolean {
         arr.add(i)
     }
 
-    val removedElement = arr.remove(2)
-    val removed = arr.remove(4: Any)
+    val removedElement = arr.removeAt(2)
+    val removed = arr.remove(4)
     return arr.size() == 4 && removedElement == 2 && removed && arr[0] == 0 && arr[1] == 1 && arr[2] == 3 && arr[3] == 5
 }

js/js.translator/testData/java/arrayList/cases/removeWithIndexOutOfBounds.kt

@@ -7,7 +7,7 @@ fun box(): Boolean {
 
     val arr = ArrayList<Int>()
     try {
-        arr.remove(2)
+        arr.removeAt(2)
     }
     catch(e: IndexOutOfBoundsException) {
         threwForEmptyList = true
@@ -20,7 +20,7 @@ fun box(): Boolean {
     var threwForFilled = false
 
     try {
-        arr.remove(20)
+        arr.removeAt(20)
     }
     catch(e: IndexOutOfBoundsException) {
         threwForFilled = true