Skip to content

Commit 9041976

Browse files
committed
Merge pull request rstudio#938 from yihui/bugfix/933
Fixes rstudio#933: make sure type is of length one
2 parents 71adee1 + acad935 commit 9041976

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Package: shiny
22
Type: Package
33
Title: Web Application Framework for R
4-
Version: 0.12.2.9000
4+
Version: 0.12.2.9001
55
Date: 2015-08-04
66
Authors@R: c(
77
person("Winston", "Chang", role = c("aut", "cre"), email = "[email protected]"),

NEWS

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ shiny 0.12.2.9000
33

44
* Fixed #902: the `drag_drop` plugin of the selectize input did not work.
55

6+
* Fixed #933: `updateSliderInput()` does not work when only the label is updated.
7+
68
shiny 0.12.2
79
--------------------------------------------------------------------------------
810

R/update-input.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@ updateSliderInput <- function(session, inputId, label = NULL, value = NULL,
285285
stop("Type mismatch for value, min, and max")
286286
}
287287

288-
if (type == "date" || type == "datetime") {
288+
if ((length(type) == 1) && (type == "date" || type == "datetime")) {
289289
to_ms <- function(x) 1000 * as.numeric(as.POSIXct(x))
290290
if (!is.null(min)) min <- to_ms(min)
291291
if (!is.null(max)) max <- to_ms(max)

0 commit comments

Comments
 (0)