Skip to content

Merge of compressed and uncompressed backup is failing #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gsmolk opened this issue Dec 7, 2018 · 1 comment
Closed

Merge of compressed and uncompressed backup is failing #38

gsmolk opened this issue Dec 7, 2018 · 1 comment

Comments

@gsmolk
Copy link
Contributor

gsmolk commented Dec 7, 2018

ERROR: test_merge_compressed_and_uncompressed_backups (tests.merge.MergeTest)

Traceback (most recent call last):
File "tests/merge.py", line 301, in test_merge_compressed_and_uncompressed_backups
self.merge_backup(backup_dir, "node", page_id)
File "tests/helpers/ptrack_helpers.py", line 680, in merge_backup
return self.run_pb(cmd_list + options, async, gdb, old_binary)
File "tests/helpers/ptrack_helpers.py", line 583, in run_pb
raise ProbackupException(e.output.decode("utf-8"), self.cmd)
ProbackupException:
ERROR: u'INFO: Merge started\nINFO: Merging backup PJCT5X with backup PJCT52\nINFO: Validating backup PJCT52\nINFO: Backup PJCT52 data files are valid\nINFO: Validating backup PJCT5X\nINFO: Backup PJCT5X data files are valid\nINFO: Delete: PJCT5X 2018-12-07 09:39:36+03\nINFO: Rename PJCT52 to PJCT5X\nINFO: Merging backup PJCT6S with backup PJCT5X\nINFO: Validating backup PJCT6S\nINFO: Backup PJCT6S data files are valid\nWARNING: An error occured during decompressing block 0 of file "/home/gsmol/git/postgres/contrib/pg_probackup/tests/tmp_dirs/merge/test_merge_compressed_and_uncompressed_backups/backup/backups/node/PJCT5X/database/base/13245/16387": Invalid compression algorithm\nERROR: page of file "/home/gsmol/git/postgres/contrib/pg_probackup/tests/tmp_dirs/merge/test_merge_compressed_and_uncompressed_backups/backup/backups/node/PJCT5X/database/base/13245/16387" uncompressed to -1 bytes. != BLCKSZ\nERROR: Data files merging failed\n'
CMD: ['/home/gsmol/git/postgres/contrib/pg_probackup/pg_probackup merge -B /home/gsmol/git/postgres/contrib/pg_probackup/tests/tmp_dirs/merge/test_merge_compressed_and_uncompressed_backups/backup --instance=node -i PJCT6S']

Looks like merge tries to decompresse file from not compressed backup.

@gsmolk
Copy link
Contributor Author

gsmolk commented Dec 13, 2018

Fixed in 23d1a26

@gsmolk gsmolk closed this as completed Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant