Skip to content

Commit 8c25f25

Browse files
ensuring backwards compatibility
1 parent 5ed1288 commit 8c25f25

File tree

3 files changed

+20
-8
lines changed

3 files changed

+20
-8
lines changed

src/EventStore.Client.Common/protos/persistentsubscriptions.proto

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,16 +98,22 @@ message CreateReq {
9898
bool resolve_links = 1;
9999
uint64 revision = 2;
100100
bool extra_statistics = 3;
101-
int64 message_timeout = 4;
102101
int32 max_retry_count = 5;
103-
int64 checkpoint_after = 6;
104102
int32 min_checkpoint_count = 7;
105103
int32 max_checkpoint_count = 8;
106104
int32 max_subscriber_count = 9;
107105
int32 live_buffer_size = 10;
108106
int32 read_batch_size = 11;
109107
int32 history_buffer_size = 12;
110108
ConsumerStrategy named_consumer_strategy = 13;
109+
oneof message_timeout {
110+
int64 message_timeout_ticks = 4;
111+
int32 message_timeout_ms = 14;
112+
}
113+
oneof checkpoint_after {
114+
int64 checkpoint_after_ticks = 6;
115+
int32 checkpoint_after_ms = 15;
116+
}
111117
}
112118

113119
enum ConsumerStrategy {
@@ -133,16 +139,22 @@ message UpdateReq {
133139
bool resolve_links = 1;
134140
uint64 revision = 2;
135141
bool extra_statistics = 3;
136-
int64 message_timeout = 4;
137142
int32 max_retry_count = 5;
138-
int64 checkpoint_after = 6;
139143
int32 min_checkpoint_count = 7;
140144
int32 max_checkpoint_count = 8;
141145
int32 max_subscriber_count = 9;
142146
int32 live_buffer_size = 10;
143147
int32 read_batch_size = 11;
144148
int32 history_buffer_size = 12;
145149
ConsumerStrategy named_consumer_strategy = 13;
150+
oneof message_timeout {
151+
int64 message_timeout_ticks = 4;
152+
int32 message_timeout_ms = 14;
153+
}
154+
oneof checkpoint_after {
155+
int64 checkpoint_after_ticks = 6;
156+
int32 checkpoint_after_ms = 15;
157+
}
146158
}
147159

148160
enum ConsumerStrategy {

src/EventStore.Client.PersistentSubscriptions/EventStorePersistentSubscriptionsClient.Create.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,9 @@ await _client.CreateAsync(new CreateReq {
4545
GroupName = groupName,
4646
Settings = new CreateReq.Types.Settings {
4747
Revision = settings.StartFrom,
48-
CheckpointAfter = (int)settings.CheckPointAfter.TotalMilliseconds,
48+
CheckpointAfterMs = (int)settings.CheckPointAfter.TotalMilliseconds,
4949
ExtraStatistics = settings.ExtraStatistics,
50-
MessageTimeout = (int)settings.MessageTimeout.TotalMilliseconds,
50+
MessageTimeoutMs = (int)settings.MessageTimeout.TotalMilliseconds,
5151
ResolveLinks = settings.ResolveLinkTos,
5252
HistoryBufferSize = settings.HistoryBufferSize,
5353
LiveBufferSize = settings.LiveBufferSize,

src/EventStore.Client.PersistentSubscriptions/EventStorePersistentSubscriptionsClient.Update.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,9 @@ await _client.UpdateAsync(new UpdateReq {
4545
GroupName = groupName,
4646
Settings = new UpdateReq.Types.Settings {
4747
Revision = settings.StartFrom,
48-
CheckpointAfter = (int)settings.CheckPointAfter.TotalMilliseconds,
48+
CheckpointAfterMs = (int)settings.CheckPointAfter.TotalMilliseconds,
4949
ExtraStatistics = settings.ExtraStatistics,
50-
MessageTimeout = (int)settings.MessageTimeout.TotalMilliseconds,
50+
MessageTimeoutMs = (int)settings.MessageTimeout.TotalMilliseconds,
5151
ResolveLinks = settings.ResolveLinkTos,
5252
HistoryBufferSize = settings.HistoryBufferSize,
5353
LiveBufferSize = settings.LiveBufferSize,

0 commit comments

Comments
 (0)