Skip to content

Rename Line's flip()/flip_ip() functions #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
itzpr3d4t0r opened this issue Jan 12, 2023 · 0 comments · Fixed by #211
Closed

Rename Line's flip()/flip_ip() functions #182

itzpr3d4t0r opened this issue Jan 12, 2023 · 0 comments · Fixed by #211
Labels
type:cleanup Includes moving code, refactoring or reformat

Comments

@itzpr3d4t0r
Copy link
Member

itzpr3d4t0r commented Jan 12, 2023

I propose renaming the current Line.flip() and Line.flip_ip() methods to flip_endpoints() and flip_endpoints_ip(), respectively. The current names are confusing as they could imply that the entire line is flipped(along x or y axis), when in fact only the endpoints are being swapped. This naming convention are in conflict with potential future functions that flip the line along the x or y axes.

The new names better describe the functionality of the methods and will prevent confusion when using them in conjunction with other line flipping methods that may be added in the future.

@itzpr3d4t0r itzpr3d4t0r added the type:cleanup Includes moving code, refactoring or reformat label Jan 12, 2023
@itzpr3d4t0r itzpr3d4t0r moved this to Todo: Line in pygame.geometry Jan 12, 2023
@github-project-automation github-project-automation bot moved this from Todo: Line to Done in pygame.geometry Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:cleanup Includes moving code, refactoring or reformat
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant