-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix Mermaid printer rendering double underscores as bold formatting #10403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10403 +/- ##
=======================================
Coverage 95.90% 95.90%
=======================================
Files 176 176
Lines 19130 19138 +8
=======================================
+ Hits 18347 18355 +8
Misses 783 783
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you. Let's wait for @DudeNr33 review before merging.
Co-authored-by: Pierre Sassoulas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the fix!
…10403) * Escape characters in mermaid viewer * Update test files * Add news fragement * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Apply suggestions from code review Co-authored-by: Pierre Sassoulas <[email protected]> --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Pierre Sassoulas <[email protected]> (cherry picked from commit 25a0f9e)
…10403) (#10410) (cherry picked from commit 25a0f9e) Co-authored-by: Julian Grimm <[email protected]> Co-authored-by: Pierre Sassoulas <[email protected]>
Type of Changes
Description
For now I am only escaping __, but other characters can easily be added aswell :)
Closes #10402