Skip to content

Broken link in MLDA example notebook #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cluhmann opened this issue Dec 11, 2023 · 3 comments · Fixed by #678
Closed

Broken link in MLDA example notebook #619

cluhmann opened this issue Dec 11, 2023 · 3 comments · Fixed by #678
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@cluhmann
Copy link
Member

Notebook title: The MLDA sampler
Notebook url: https://www.pymc.io/projects/examples/en/latest/samplers/MLDA_simple_linear_regression.html

Issue description

The notebook contains this text:

The model is similar to the one used in https://docs.pymc.io/notebooks/GLM-linear.html.

But the URL is not a link and is non-operational.

Proposed solution

The linking explanatiion/guidance found here should be used to appropriately use sphinx links to the relevnat notebook.

@cluhmann cluhmann added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 11, 2023
@OriolAbril
Copy link
Member

The url should be replaced by {ref}`pymc:glm_linear`

th0rwas added a commit to th0rwas/pymc-examples that referenced this issue Jun 15, 2024
@pradyutf
Copy link
Contributor

Hi @cluhmann ,

I saw the solution proposed in the comments for this issue, and I believe it will fix the problem because it follows the guidelines and has been referenced in a file. I've attached a screenshot for reference.
Screenshot 2024-07-30 at 12 08 05 AM

Would you like me to raise a PR to implement this fix?

Thanks

@cluhmann
Copy link
Member Author

That would be fantastic!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants