Add ruff rules PIE (#5033)

Author: abravalheri

newsfragments/5033.misc.rst

@@ -0,0 +1 @@
+Avoid repeated calls to ``str.startswith`` and ``str.endswith``.

ruff.toml

@@ -29,6 +29,7 @@ extend-select = [
 	"ISC", # flake8-implicit-str-concat
 	"FURB", # refurb
 	"PERF", # Perflint
+	"PIE", # flake8-pie
 	"PGH", # pygrep-hooks (blanket-* rules)
 	"PT", # flake8-pytest-style
 	"RUF10", # unused-noqa & redirected-noqa

setuptools/command/bdist_egg.py

@@ -348,9 +348,9 @@ def analyze_egg(egg_dir, stubs):
     safe = True
     for base, dirs, files in walk_egg(egg_dir):
         for name in files:
-            if name.endswith('.py') or name.endswith('.pyw'):
+            if name.endswith(('.py', '.pyw')):
                 continue
-            elif name.endswith('.pyc') or name.endswith('.pyo'):
+            elif name.endswith(('.pyc', '.pyo')):
                 # always scan, even if we already know we're not safe
                 safe = scan_module(egg_dir, base, name, stubs) and safe
     return safe

setuptools/command/egg_info.py

@@ -146,7 +146,7 @@ def _maybe_tag(self, version):
     def _already_tagged(self, version: str) -> bool:
         # Depending on their format, tags may change with version normalization.
         # So in addition the regular tags, we have to search for the normalized ones.
-        return version.endswith(self.vtags) or version.endswith(self._safe_tags())
+        return version.endswith((self.vtags, self._safe_tags()))
 
     def _safe_tags(self) -> str:
         # To implement this we can rely on `safe_version` pretending to be version 0