reuse the generate binary builds from test-infra #3515
+56
−801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoid heavy maintainance on our side If we want to modify the output, do it in our filter-matrix step
lanluo-nvidia
added
the
WIP
lanluo-nvidia
removed
the
WIP
narendasan
reviewed
May 12, 2025
| if item["python_version"] not in disabled_python_versions: | ||
| if item["python_version"] in disabled_python_versions: | ||
| continue | ||
| if options.limit_pr_builds == "true": |
There was a problem hiding this comment.
I think that instead of by default not testing multiple cuda we might want to think about testing phases to catch meaningful errors early #3501
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reuse the generate binary builds from test-infra
avoid heavy maintainance on our side
If we want to modify the generate binary build output, do it in our filter-matrix step.
https://github.com/pytorch/TensorRT/blob/main/.github/workflows/build-test-linux.yml#L27
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: