-
Notifications
You must be signed in to change notification settings - Fork 35
Feature request for transformers
use-cases
#673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks a lot for the great feedback!
|
Thanks a lot @NicolasHug ! Looking forward for future releases 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🚀 The feature
Hi 👋
First of all, huge thanks to you and the team, the latest
torchcodec
release with audio support is fantastic! It's a long-awaited featureI'm the maintainer of multimodal models in
transformers
and I'm thinking to usetorchcodec
to load multimodal data for MLLMs. Looking forward for a stable version to be released. For now, I’ve been testing the latest release and noticed a few points that might be useful to consider for future support.Mono channel audio support: Some audio models (like Whisper from Hugging Face) only support mono-channel input. It would be helpful if audio loading allowed channel selection or converted stereo to mono optionally.
Fallback for video files with no audio: When loading audio from a video file that has no audio stream, an error is raised currently. A more flexible behavior would be to return
None
, similar to howmoviepy
handles it and can be checked asif clip.audio is not None
.Loading from URL: Loading audio/video from URLs seems to work for some urls I have tested with, though I couldn’t find in the docs whether URL input is officially supported. Hope it will be officially supported for the stable release
Video decoder issues with
avi
format: When trying to loadavi
files, the decoder fails to infer duration and related metadata, which prevents sampling frames by seconds. Loading the same video saved asmp4
resolves the issue. You can try this video as an example.Let me know if you'd like me to file any of these separately or provide reproducible examples. Thanks again for the awesome work!
Motivation, pitch
No response
The text was updated successfully, but these errors were encountered: