Skip to content

Commit 6539f9d

Browse files
author
Niklas von Hertzen
committed
Fix webdriver tests for node 4.0
1 parent 3cb0911 commit 6539f9d

File tree

3 files changed

+29
-7
lines changed

3 files changed

+29
-7
lines changed

package.json

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,15 @@
3535
"html2canvas-proxy": "0.0.5",
3636
"humanize-duration": "^2.0.1",
3737
"lodash": "^3.10.1",
38-
"png-js": "^0.1.1",
38+
"pngjs": "^2.2.0",
3939
"requirejs": "^2.1.20",
40+
"sauce-connect-launcher": "^0.13.0",
4041
"wd": "^0.4.0"
4142
},
4243
"scripts": {
43-
"test": "grunt travis --verbose"
44+
"test": "grunt travis --verbose",
45+
"start": "grunt server",
46+
"sauceconnect": "tests/sauceconnect.js"
4447
},
4548
"homepage": "http://html2canvas.hertzen.com",
4649
"license": "MIT"

tests/sauceconnect.js

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
const sauceConnectLauncher = require('sauce-connect-launcher');
2+
3+
sauceConnectLauncher({
4+
username: process.env.SAUCE_USERNAME,
5+
accessKey: process.env.SAUCE_ACCESS_KEY,
6+
logger: console.log
7+
}, err => {
8+
if (err) {
9+
console.error(err.message);
10+
return;
11+
}
12+
console.log('Sauce Connect ready');
13+
});

tests/selenium.js

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
url = require("url"),
77
path = require("path"),
88
base64_arraybuffer = require('base64-arraybuffer'),
9-
PNG = require('png-js'),
9+
PNG = require('pngjs').PNG,
1010
Promise = require('bluebird'),
1111
_ = require('lodash'),
1212
humanizeDuration = require("humanize-duration"),
@@ -20,9 +20,15 @@
2020
var port = 8080;
2121

2222
function getPixelArray(base64) {
23-
return new Promise(function(resolve) {
24-
var arraybuffer = base64_arraybuffer.decode(base64);
25-
(new PNG(arraybuffer)).decodePixels(resolve);
23+
return new Promise(function(resolve, reject) {
24+
const arraybuffer = base64_arraybuffer.decode(base64);
25+
new PNG().parse(arraybuffer, (error, data) => {
26+
if (error) {
27+
reject(error);
28+
} else {
29+
resolve(data.data);
30+
}
31+
});
2632
});
2733
}
2834

@@ -78,7 +84,7 @@
7884
return Promise.resolve(browser
7985
.then(utils.loadTestPage(browser, test, port))
8086
.then(captureScreenshots(browser))
81-
.then(analyzeResults(test))).cancellable();
87+
.then(analyzeResults(test)));
8288
}
8389

8490
exports.tests = function(browsers, singleTest) {

0 commit comments

Comments
 (0)