Skip to content

Commit f1c046e

Browse files
fix(tabs): Remove tab animation on active tab (#3658)
* fix(tabs): Remove tab animation on active tab * fix(tabs): Remove ref to keyframes
1 parent edf2190 commit f1c046e

File tree

3 files changed

+10
-17
lines changed

3 files changed

+10
-17
lines changed

RELEASENOTES.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@
44
## Release 2.8.3 - February 4, 2019
55

66
## Components
7+
### [Tabs](https://www.lightningdesignsystem.com/components/tabs)
8+
#### Changed
9+
- Removed animation when invoking an active tab
10+
711
### [Global Navigation](https://www.lightningdesignsystem.com/components/global-navigation)
812
#### Fixed
913
- Fixed issue where a navigation item would lose its background color when active and/or hovered.

ui/components/tabs/RELEASENOTES.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,12 @@
33
# Tabs Release Notes
44

55
<!-- ## [Unreleased] -->
6+
## 2.8.3
7+
8+
### Changed
9+
10+
- Removed animation when invoking an active tab
11+
612
## 2.8.0
713

814
### Added

ui/components/tabs/base/_index.scss

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -3,22 +3,6 @@
33

44
@import 'deprecate';
55

6-
// Animation for `slds-is-active` state
7-
@keyframes shadow {
8-
9-
0% {
10-
box-shadow: inset 0 0 $brand-light;
11-
}
12-
13-
50% {
14-
box-shadow: inset 0 rem(-30px) $brand-primary-transparent-40;
15-
}
16-
17-
100% {
18-
box-shadow: inset 0 rem(-40px) $brand-light;
19-
}
20-
}
21-
226
/**
237
* @summary Initializes a default tablist
248
*
@@ -88,7 +72,6 @@
8872
&.slds-active,
8973
&.slds-is-active {
9074
color: $color-text-action-label-active;
91-
animation: shadow 300ms;
9275

9376
&:after {
9477
background-color: $brand-primary;

0 commit comments

Comments
 (0)