Skip to content
This repository was archived by the owner on Nov 16, 2020. It is now read-only.

cluster_formation.peer_discovery_backend aliases #34

Closed
michaelklishin opened this issue Jun 2, 2020 · 1 comment · Fixed by #35
Closed

cluster_formation.peer_discovery_backend aliases #34

michaelklishin opened this issue Jun 2, 2020 · 1 comment · Fixed by #35
Assignees
@michaelklishin
Milestone
3.8.5

Comments

@michaelklishin
Copy link
Contributor

This plugin's name is rabbitmq_peer_discovery_aws but the module name that must be configured for discovery is

cluster_formation.peer_discovery_backend = rabbit_peer_discovery_aws

which confuses some users and leads to hours spent troubleshooting and a lot of frustration.

We should introduce an alias module and consider an alias shortcut supported in rabbitmq.conf so that these config values

cluster_formation.peer_discovery_backend = rabbitmq_peer_discovery_aws
cluster_formation.peer_discovery_backend = aws

would be accepted.
@michaelklishin michaelklishin added this to the 3.8.5 milestone Jun 2, 2020
@michaelklishin michaelklishin self-assigned this Jun 2, 2020
michaelklishin added a commit that referenced this issue Jun 2, 2020
@michaelklishin
Alias rabbit_peer_discovery_aws as rabbitmq_peer_discovery_aws
b4043ac 
So that if someone assumes that the discovery module name is the same
as plugin name, they don't have to troubleshoot `undef' exceptions.

Closes #34
@michaelklishin michaelklishin mentioned this issue Jun 2, 2020
Merged
@michaelklishin
Copy link
Contributor Author

FTR, short names have been supported since 3.7.0: rabbitmq/rabbitmq-server@5f9752c, rabbitmq/rabbitmq-server@245e3c7

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@michaelklishin michaelklishin

Labels
None yet
Projects
None yet
Milestone
3.8.5
Development

Successfully merging a pull request may close this issue.

Alias rabbit_peer_discovery_aws as rabbitmq_peer_discovery_aws rabbitmq/rabbitmq-peer-discovery-aws
1 participant
@michaelklishin