Could not compile from `master` @ 21bf511f93dd94a5ac05626b5a94c70d7492d427

[alanjds]

I am trying to compile on master @ 21bf511f93dd94a5ac05626b5a94c70d7492d427 (Save my work at micropython-wasm), but is not compiling:

$ time make
Use make V=1 or set BUILD_VERBOSE in your environment to increase build verbosity.
mkdir -p build/genhdr
GEN build/genhdr/mpversion.h
GEN build/genhdr/moduledefs.h
GEN build/genhdr/qstr.i.last
GEN build/genhdr/qstr.split
GEN build/genhdr/qstrdefs.collected.h
QSTR updated
GEN build/genhdr/qstrdefs.generated.h
mkdir -p build/extmod
mkdir -p build/lib/embed
mkdir -p build/lib/mp-readline
mkdir -p build/lib/utils
mkdir -p build/py
CC ../../py/mpstate.c
(...)
CC ../../lib/mp-readline/readline.c
CC main.c
CC mphalport.c
CC modutime.c
LINK build/firmware.js
emcc:WARNING: ignoring unsupported linker flag: `-Map=build/micropython.js.map`
emcc:WARNING: ignoring unsupported linker flag: `--cref`
emcc:WARNING: ignoring unsupported linker flag: `--gc-sections`
error: undefined symbol: mp_module_js
warning: To disable errors for undefined symbols use `-s ERROR_ON_UNDEFINED_SYMBOLS=0`
Error: Aborting compilation due to previous errors
shared:ERROR: '/Users/alanjds/src/git/emsdk/node/8.9.1_64bit/bin/node /Users/alanjds/src/git/emsdk/fastcomp/emscripten/src/compiler.js /tmp/tmpvPCwWN.txt /Users/alanjds/src/git/micropython/ports/javascript/library.js /Users/alanjds/src/git/emsdk/fastcomp/emscripten/src/library_pthread_stub.js' failed (1)
make: *** [build/micropython.js] Error 1

real	0m50.846s
user	0m31.518s
sys	0m18.148s

Am I doing something wrong?

[alanjds]

Added js.c and it compiled and linked, and the error changed:

Error on console:

micropython.js:1776 wasm streaming compile failed: TypeError: Failed to execute 'compile' on 'WebAssembly': Incorrect response MIME type. Expected 'application/wasm'.
micropython.js:1777 falling back to ArrayBuffer instantiation
(index):1 Uncaught (in promise) bad or missing emterpreter file. If you compiled to JS (and not HTML) make sure you set Module['emterpreterFile']

Applied patch:

diff --git a/ports/javascript/Makefile b/ports/javascript/Makefile
index f0851bd44..33276afd3 100644
--- a/ports/javascript/Makefile
+++ b/ports/javascript/Makefile
@@ -36,6 +36,7 @@ SRC_C = \
     main.c \
     mphalport.c \
     modutime.c \
+    js.c \

 SRC_QSTR += $(SRC_C)

[rafi16jan]

Are you referring to this fork?

[rafi16jan]

Added js.c and it compiled and linked, and the error changed:

Error on console:

micropython.js:1776 wasm streaming compile failed: TypeError: Failed to execute 'compile' on 'WebAssembly': Incorrect response MIME type. Expected 'application/wasm'.
micropython.js:1777 falling back to ArrayBuffer instantiation
(index):1 Uncaught (in promise) bad or missing emterpreter file. If you compiled to JS (and not HTML) make sure you set Module['emterpreterFile']

Applied patch:

diff --git a/ports/javascript/Makefile b/ports/javascript/Makefile
index f0851bd44..33276afd3 100644
--- a/ports/javascript/Makefile
+++ b/ports/javascript/Makefile
@@ -36,6 +36,7 @@ SRC_C = \
     main.c \
     mphalport.c \
     modutime.c \
+    js.c \

 SRC_QSTR += $(SRC_C)

I hack some lines in lib/micropython.js to load the emterpreterFile, the ones that need webpack loaders or fs module https://github.com/rafi16jan/micropython-wasm/blob/master/lib/micropython.js#L79-L88

This line:
micropython.js:1776 wasm streaming compile failed: TypeError: Failed to execute 'compile' on 'WebAssembly': Incorrect response MIME type. Expected 'application/wasm'.

May refer to firmware.wasm that I mention to you earlier, check the network tab. I will make my fork should work flawlessly after make command but I think I made a lot of changes on lib/micropython.js that should been applied to wrapper.js on the port folder. Thank you for your feedbacks and reports, I appreciate it

[rafi16jan]

I enable issue there if you want to track reports separately from the NPM module repo.

[alanjds]

Are you referring to this fork?

Yes.

I enable issue there if you want to track reports separately from the NPM module repo.

Thanks. I got confused when the issues tab disappeared. Now I see that this repo here is for the NPM package. The other is for the Micropython port customizations.

I am pursuing to have the time.sleep() unlock the JS thread, or at least the await asyncio.sleep(). Then will try to bake a real PR on the upstream micropython.

[alanjds]

Btw, looks like some race conditions occur on load of build/micropython.js, so I am using this index.html on my tests:

<!doctype html>
<html>
  <head>
    <script src="build/micropython.js"></script>
  </head>
  <body>
    <div id='mp_js_stdout'></div>
    <script>
      var out = document.getElementById('mp_js_stdout');
      out.addEventListener('print', function(e) {
        out.innerHTML += e.data;
      }, false);

      var initializer = setInterval(function() {
        try{
            mp_js_init(64 * 1024);
        }
        catch(err){
            console.log('Waiting micropython initialization');
            return;
        }
        clearInterval(initializer);
        console.log('Micropython initialized.');

        mp_js_do_str('print(\'hello world from micropython\')');
      }, 30);
    </script>
  </body>
</html>

Usually it takes about 90ms to initialize on my computer...

[alanjds]

Got it...

micropython-wasm/lib/micropython.js

Lines 79 to 88 in 0672c9e

	if (typeof webpackJsonp !== 'object') {
	const fs = require('fs')
	const path = require('path')
	console.log(fs)
	const file = fs.readFileSync(__dirname + '/micropython.binary');
	Module.emterpreterFile = file.buffer.slice(file.byteOffset, file.byteOffset + file.byteLength);
	}
	else {
	Module.emterpreterFile = require('!arraybuffer-loader!' + './micropython.binary');
	}

This is when the "missing emterpreter file" is installed, right?