Skip to content

Commit 1d75f4a

Browse files
DmitriyZaitsevakarnokd
authored andcommitted
1.x: provide an explanation why certain tests are ignored (ReactiveX#4118)
1 parent 4210577 commit 1d75f4a

File tree

4 files changed

+4
-5
lines changed

4 files changed

+4
-5
lines changed

src/test/java/rx/BackpressureTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ public Observable<Integer> call(Integer i) {
192192
}
193193

194194
@Test
195-
@Ignore // the test is non-deterministic and can't be made deterministic
195+
@Ignore("The test is non-deterministic and can't be made deterministic")
196196
public void testFlatMapAsync() {
197197
int NUM = (int) (RxRingBuffer.SIZE * 2.1);
198198
AtomicInteger c = new AtomicInteger();

src/test/java/rx/IntervalDemo.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,7 @@
2525
import rx.functions.Action0;
2626
import rx.functions.Action1;
2727

28-
@Ignore
29-
// since this doesn't do any automatic testing
28+
@Ignore("Since this doesn't do any automatic testing")
3029
public class IntervalDemo {
3130

3231
@Test

src/test/java/rx/internal/operators/OperatorFlatMapTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -430,7 +430,7 @@ public void testFlatMapTransformsMaxConcurrentNormal() {
430430
verify(o, never()).onError(any(Throwable.class));
431431
}
432432

433-
@Ignore // don't care for any reordering
433+
@Ignore("Don't care for any reordering")
434434
@Test(timeout = 10000)
435435
public void flatMapRangeAsyncLoop() {
436436
for (int i = 0; i < 2000; i++) {

src/test/java/rx/observers/SerializedObserverTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,7 @@ public void onCompleted() {
336336
*
337337
* @throws InterruptedException
338338
*/
339-
@Ignore
339+
@Ignore("Demonstrates thread starvation problem. Read JavaDoc")
340340
@Test
341341
public void testThreadStarvation() throws InterruptedException {
342342

0 commit comments

Comments
 (0)