Skip to content

Commit a9be73c

Browse files
cloud-pharaohbharathkkbmorgante
authored
fix: update ASM mode var description (terraform-google-modules#910)
* update key_file variable name and upgrade mode * revert key_file rename Co-authored-by: Bharath KKB <[email protected]> Co-authored-by: Morgante Pell <[email protected]>
1 parent 0c5f363 commit a9be73c

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

modules/asm/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ To deploy this config:
6969
| key\_file | The GCP Service Account credentials file path used to deploy ASM. | `string` | `""` | no |
7070
| location | The location (zone or region) this cluster has been created in. | `string` | n/a | yes |
7171
| managed\_control\_plane | ASM managed control plane boolean. Determines whether to install ASM managed control plane. Installing ASM managed control plane does not install gateways. Documentation on how to install gateways with ASM MCP can be found at https://cloud.google.com/service-mesh/docs/managed-control-plane#install_istio_gateways_optional. | `bool` | `false` | no |
72-
| mode | ASM mode for deployment. Supported mode is `install` only. | `string` | `"install"` | no |
72+
| mode | ASM mode for deployment. Supported modes are `install` and `upgrade`. | `string` | `"install"` | no |
7373
| options | Comma separated list of options. Works with in-cluster control plane only. Supported options are documented in https://cloud.google.com/service-mesh/docs/enable-optional-features. | `list` | `[]` | no |
7474
| outdir | Sets `--outdir` option. | `string` | `"none"` | no |
7575
| project\_id | The project in which the resource belongs. | `string` | n/a | yes |

modules/asm/variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ variable "asm_git_tag" {
6464
}
6565

6666
variable "mode" {
67-
description = "ASM mode for deployment. Supported mode is `install` only."
67+
description = "ASM mode for deployment. Supported modes are `install` and `upgrade`."
6868
type = string
6969
default = "install"
7070
}

0 commit comments

Comments
 (0)