Skip to content

Commit e6ffede

Browse files
committed
t9390: avoid using Bash-ism <(...)
The problem with this is that on Windows, we use the MSYS2 Bash which uses the POSIX emulation layer called "MSYS2 runtime" that pretends that there _is_ something like the `/dev/fd/` namespace, and tells `git.exe` about it, but `git.exe` does not use the POSIX emulation layer, and hence has no idea what Bash is talking about. Besides, we should avoid pipes, just as we do in the Git project. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 8bc1956 commit e6ffede

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

t/t9390-filter-repo.sh

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -917,7 +917,8 @@ test_expect_success '--strip-blobs-with-ids' '
917917
grep fake_submodule ../filenames &&
918918
919919
# Strip "a certain file" files
920-
git filter-repo --strip-blobs-with-ids <(echo deadbeefdeadbeefdeadbeefdeadbeefdeadbeef) &&
920+
echo deadbeefdeadbeefdeadbeefdeadbeefdeadbeef >../input &&
921+
git filter-repo --strip-blobs-with-ids ../input &&
921922
922923
git log --format=%n --name-only | sort | uniq >../filenames &&
923924
test_line_count = 10 ../filenames &&
@@ -1232,10 +1233,12 @@ test_expect_success 'other startup error cases and requests for help' '
12321233
test_must_fail git filter-repo --path-rename foo:bar/ 2>err &&
12331234
test_i18ngrep "either ends with a slash then both must." err &&
12341235
1235-
test_must_fail git filter-repo --paths-from-file <(echo "foo==>bar/") 2>err &&
1236+
echo "foo==>bar/" >input &&
1237+
test_must_fail git filter-repo --paths-from-file input 2>err &&
12361238
test_i18ngrep "either ends with a slash then both must." err &&
12371239
1238-
test_must_fail git filter-repo --paths-from-file <(echo "glob:*.py==>newname") 2>err &&
1240+
echo "glob:*.py==>newname" >input &&
1241+
test_must_fail git filter-repo --paths-from-file input 2>err &&
12391242
test_i18ngrep "renaming globs makes no sense" err &&
12401243
12411244
test_must_fail git filter-repo --strip-blobs-bigger-than 3GiB 2>err &&
@@ -1358,7 +1361,8 @@ test_expect_success '--refs and --replace-text' '
13581361
git clone file://"$(pwd)"/path_rename refs_and_replace_text &&
13591362
cd refs_and_replace_text &&
13601363
git rev-parse --short=10 HEAD~1 >myparent &&
1361-
git filter-repo --force --replace-text <(echo "10==>TEN") --refs $(cat myparent)..master &&
1364+
echo "10==>TEN" >input &&
1365+
git filter-repo --force --replace-text input --refs $(cat myparent)..master &&
13621366
cat <<-EOF >expect &&
13631367
TEN11
13641368
EOF
@@ -1629,7 +1633,8 @@ test_expect_success 'degenerate merge with typechange' '
16291633
git ls-files >actual &&
16301634
test_cmp expect actual &&
16311635
1632-
test_line_count = 2 <(git log --oneline HEAD)
1636+
git log --oneline HEAD >input &&
1637+
test_line_count = 2 input
16331638
)
16341639
'
16351640

0 commit comments

Comments
 (0)