Skip to content

Commit c176fe9

Browse files
author
Peter
committed
make it more robust for big data sets
1 parent 2f969d0 commit c176fe9

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

src/main/java/com/graphhopper/reader/OSMReader.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,8 @@ public static OSMReader osm2Graph(final CmdArgs args) throws IOException {
118118
}
119119

120120
int size = (int) args.getLong("osmreader.size", 10 * 1000);
121+
if (size < 1)
122+
throw new IllegalArgumentException("Invalid osmreader.size value " + size);
121123
GraphStorage storage;
122124
String dataAccess = args.get("osmreader.dataaccess", "inmemory+save");
123125
Directory dir;

src/main/java/com/graphhopper/reader/OSMReaderHelper.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,8 @@
3333
*/
3434
public abstract class OSMReaderHelper {
3535

36-
private final Logger logger = LoggerFactory.getLogger(getClass());
37-
protected int counter = 0;
38-
protected int zeroCounter = 0;
36+
private final Logger logger = LoggerFactory.getLogger(getClass());
37+
protected long zeroCounter = 0;
3938
protected final Graph g;
4039
protected final int expectedNodes;
4140
private DistanceCalc callback = new DistanceCalc();
@@ -96,7 +95,7 @@ int addEdge(int fromIndex, int toIndex, PointList pointList, int flags) {
9695
}
9796

9897
String getInfo() {
99-
return "Found " + zeroCounter + " zero and " + counter + " negative distances.";
98+
return "Found " + zeroCounter + " zero distances.";
10099
}
101100

102101
String getStorageInfo(GraphStorage storage) {

src/main/java/com/graphhopper/reader/OSMReaderHelperDoubleParse.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ public void preProcess(InputStream osmXml) {
236236
XMLStreamReader sReader = null;
237237
try {
238238
sReader = factory.createXMLStreamReader(osmXml, "UTF-8");
239-
int tmpCounter = 1;
239+
long tmpCounter = 1;
240240
for (int event = sReader.next(); event != XMLStreamConstants.END_DOCUMENT;
241241
event = sReader.next(), tmpCounter++) {
242242
if (tmpCounter % 20000000 == 0)

0 commit comments

Comments
 (0)