Skip to content

Commit 2220ecc

Browse files
committed
[fix ptmt#53] Make UIExplorer independent on argc == 0, fix release packaging
1 parent 636f93a commit 2220ecc

File tree

4 files changed

+25
-2
lines changed

4 files changed

+25
-2
lines changed

Examples/UIExplorer/UIExplorer.xcodeproj/project.pbxproj

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -504,6 +504,7 @@
504504
13B07F871A680F5B00A75B9A /* Sources */,
505505
13B07F8C1A680F5B00A75B9A /* Frameworks */,
506506
13B07F8E1A680F5B00A75B9A /* Resources */,
507+
031465E81CAE4FC70005E5B6 /* ShellScript */,
507508
);
508509
buildRules = (
509510
);
@@ -693,6 +694,22 @@
693694
};
694695
/* End PBXResourcesBuildPhase section */
695696

697+
/* Begin PBXShellScriptBuildPhase section */
698+
031465E81CAE4FC70005E5B6 /* ShellScript */ = {
699+
isa = PBXShellScriptBuildPhase;
700+
buildActionMask = 2147483647;
701+
files = (
702+
);
703+
inputPaths = (
704+
);
705+
outputPaths = (
706+
);
707+
runOnlyForDeploymentPostprocessing = 0;
708+
shellPath = /bin/sh;
709+
shellScript = "if [$CONFIGURATION -eq Debug]\n then\n echo \"Skipping bundling for Debug\"\n exit 0;\nfi\n\nset -x\n\nDEST=$CONFIGURATION_BUILD_DIR/$UNLOCALIZED_RESOURCES_FOLDER_PATH\n\nnode \"../../local-cli/cli.js\" bundle \\\n--entry-file Examples/UIExplorer/UIExplorerApp.osx.js \\\n--platform osx \\\n--dev false \\\n--bundle-output \"$DEST/main.jsbundle\" \\\n--assets-dest \"$DEST\"";
710+
};
711+
/* End PBXShellScriptBuildPhase section */
712+
696713
/* Begin PBXSourcesBuildPhase section */
697714
004D289A1AAF61C70097A701 /* Sources */ = {
698715
isa = PBXSourcesBuildPhase;

Examples/UIExplorer/UIExplorer/AppDelegate.m

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,4 +204,8 @@ - (void)redo
204204
[[[self window] undoManager] redo];
205205
}
206206

207+
- (BOOL)applicationShouldTerminateAfterLastWindowClosed:(NSApplication * __unused)theApplication {
208+
return YES;
209+
}
210+
207211
@end

Examples/UIExplorer/UIExplorer/main.m

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ int main(__unused int argc, char* argv[]) {
2828
[argvArray addObject:[[NSString alloc] initWithUTF8String:argv[i]]];
2929
}
3030
[appDelegate setArgv:argvArray];
31+
} else {
32+
[appDelegate setArgv:[[NSArray alloc] init]];
3133
}
3234

3335
[application run];

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Build OS X desktop apps using React Native.
1515

1616
## Getting started
1717

18-
**Disclaimer**. Having previous experience with React Native highly recommended. There is no success story for any RN desktop app yet, so it's not proven by production.
18+
**Disclaimer**. Having previous experience with React Native highly recommended. There is no success story for any RN desktop app yet, so it's not proven by production.
1919

2020
``` bash
2121
$ npm install react-native-desktop-cli -g
@@ -33,7 +33,7 @@ Support development on Patreon: https://www.patreon.com/reactnativedesktop
3333

3434
## Examples
3535

36-
[Download UIExplorer](https://github.com/ptmt/react-native-desktop/files/198284/UIExplorer.zip)
36+
[Download UIExplorer](https://github.com/ptmt/react-native-desktop/files/199128/UIExplorer.zip)
3737

3838
UIExplorer includes a set of examples and allows to you load external js bundle by http. Just copy&paste URL into SearchField.
3939

0 commit comments

Comments
 (0)