Fix updating the scroll view when changing the settings

Author: mickael-menu

CHANGELOG.md

@@ -8,6 +8,12 @@ All notable changes to this project will be documented in this file. Take a look
 
 * The Readium Swift toolkit now requires a minimum of iOS 13.4.
 
+### Added
+
+#### Navigator
+
+* The `EPUBNavigatorViewController.Configuration.disablePageTurnsWhileScrolling` property disables horizontal swipes for navigating to previous or next resources when scroll mode is enabled. When set to `true`, you must implement your own mechanism to move to the next resource (contributed by [@alecdhansen](https://github.com/readium/swift-toolkit/pull/531)).
+
 ### Changed
 
 #### Shared

Package.resolved

@@ -68,6 +68,9 @@ open class EPUBNavigatorViewController: UIViewController,
         /// `UIViewController` wrapping the `EPUBNavigatorViewController`.
         public var editingActions: [EditingAction]
 
+        /// Disables horizontal page turning when scroll is enabled.
+        public var disablePageTurnsWhileScrolling: Bool
+
         /// Content insets used to add some vertical margins around reflowable EPUB publications.
         /// The insets can be configured for each size class to allow smaller margins on compact
         /// screens.
@@ -92,14 +95,12 @@ open class EPUBNavigatorViewController: UIViewController,
 
         /// Logs the state changes when true.
         public var debugState: Bool
-        
-        /// Disables horizontal page turning when scroll is enabled.
-        public let disablePageTurnsWhileScrolling: Bool
-        
+
         public init(
             preferences: EPUBPreferences = .empty,
             defaults: EPUBDefaults = EPUBDefaults(),
             editingActions: [EditingAction] = EditingAction.defaultActions,
+            disablePageTurnsWhileScrolling: Bool = false,
             contentInset: [UIUserInterfaceSizeClass: EPUBContentInsets] = [
                 .compact: (top: 20, bottom: 20),
                 .regular: (top: 44, bottom: 44),
@@ -109,20 +110,19 @@ open class EPUBNavigatorViewController: UIViewController,
             decorationTemplates: [Decoration.Style.Id: HTMLDecorationTemplate] = HTMLDecorationTemplate.defaultTemplates(),
             fontFamilyDeclarations: [AnyHTMLFontFamilyDeclaration] = [],
             readiumCSSRSProperties: CSSRSProperties = CSSRSProperties(),
-            debugState: Bool = false,
-            disablePageTurnsWhileScrolling: Bool = false
+            debugState: Bool = false
         ) {
             self.preferences = preferences
             self.defaults = defaults
             self.editingActions = editingActions
+            self.disablePageTurnsWhileScrolling = disablePageTurnsWhileScrolling
             self.contentInset = contentInset
             self.preloadPreviousPositionCount = preloadPreviousPositionCount
             self.preloadNextPositionCount = preloadNextPositionCount
             self.decorationTemplates = decorationTemplates
             self.fontFamilyDeclarations = fontFamilyDeclarations
             self.readiumCSSRSProperties = readiumCSSRSProperties
             self.debugState = debugState
-            self.disablePageTurnsWhileScrolling = disablePageTurnsWhileScrolling
         }
     }
 
@@ -522,7 +522,7 @@ open class EPUBNavigatorViewController: UIViewController,
             frame: .zero,
             preloadPreviousPositionCount: hasPositions ? config.preloadPreviousPositionCount : 0,
             preloadNextPositionCount: hasPositions ? config.preloadNextPositionCount : 0,
-            isScrollEnabled: isPaginationViewScrollingEnabled(with: settings)
+            isScrollEnabled: isPaginationViewScrollingEnabled
         )
         view.delegate = self
         view.backgroundColor = .clear
@@ -614,10 +614,10 @@ open class EPUBNavigatorViewController: UIViewController,
 
     // MARK: - Navigator
 
-    private func isPaginationViewScrollingEnabled(with settings: EPUBSettings) -> Bool {
+    private var isPaginationViewScrollingEnabled: Bool {
         !(config.disablePageTurnsWhileScrolling && settings.scroll)
     }
-    
+
     public var presentation: VisualNavigatorPresentation {
         VisualNavigatorPresentation(
             readingProgression: settings.readingProgression,
@@ -854,6 +854,7 @@ open class EPUBNavigatorViewController: UIViewController,
         }
 
         view.backgroundColor = settings.effectiveBackgroundColor.uiColor
+        paginationView.isScrollEnabled = isPaginationViewScrollingEnabled
     }
 
     // MARK: - User interactions
@@ -912,7 +913,7 @@ open class EPUBNavigatorViewController: UIViewController,
 extension EPUBNavigatorViewController: EPUBNavigatorViewModelDelegate {
     func epubNavigatorViewModelInvalidatePaginationView(_ viewModel: EPUBNavigatorViewModel) {
         Task {
-            paginationView.isScrollEnabled = isPaginationViewScrollingEnabled(with: viewModel.settings)
+            paginationView.isScrollEnabled = isPaginationViewScrollingEnabled
             await reloadSpreads(force: true)
         }
     }

Sources/Navigator/EPUB/EPUBNavigatorViewController.swift

@@ -94,8 +94,10 @@ final class PaginationView: UIView, Loggable {
     private let scrollView = UIScrollView()
 
     /// Allows the scroll view to scroll.
-    var isScrollEnabled: Bool
-    
+    var isScrollEnabled: Bool {
+        didSet { scrollView.isScrollEnabled = isScrollEnabled }
+    }
+
     init(
         frame: CGRect,
         preloadPreviousPositionCount: Int,
@@ -105,7 +107,7 @@ final class PaginationView: UIView, Loggable {
         self.preloadPreviousPositionCount = preloadPreviousPositionCount
         self.preloadNextPositionCount = preloadNextPositionCount
         self.isScrollEnabled = isScrollEnabled
-        
+
         super.init(frame: frame)
 
         scrollView.delegate = self

Sources/Navigator/Toolkit/PaginationView.swift

@@ -429,7 +429,7 @@ public final class DefaultHTTPClient: HTTPClient, Loggable {
                 return
             }
 
-            var response = HTTPResponse(request: request, response: urlResponse, url: url)
+            let response = HTTPResponse(request: request, response: urlResponse, url: url)
 
             guard response.status.isSuccess else {
                 state = .failure(continuation: continuation, error: .errorResponse(response))

Sources/Shared/Toolkit/HTTP/DefaultHTTPClient.swift

@@ -37,7 +37,7 @@ class EPUBViewController: VisualReaderViewController<EPUBNavigatorViewController
         let navigator = try EPUBNavigatorViewController(
             publication: publication,
             initialLocation: locator,
-            config: .init(
+            config: EPUBNavigatorViewController.Configuration(
                 preferences: initialPreferences,
                 editingActions: EditingAction.defaultActions
                     .appending(EditingAction(