openSUSE Tumbleweed i586 with redis 8 don't pass test_add_elem_no_quant tests

[13ilya]

https://build.opensuse.org/package/show/home:13ilya/redis
https://build.opensuse.org/package/show/home:13ilya/python-redis

In openSUSE Tumbleweed with the latest versions of redis 8.0.2 and python-redis 6.2.0 on the i586 architecture, three tests (test_add_elem_no_quant) fail, although they pass on x86_64 and aarch64.

[  189s] =================================== FAILURES ===================================
[  189s] ________________________ test_add_elem_no_quant[single] ________________________
[  189s] 
[  189s] d_client = <redis.asyncio.client.Redis(<redis.asyncio.connection.ConnectionPool(<redis.asyncio.connection.Connection(host=localhost,port=6379,db=0)>)>)>
[  189s] 
[  189s]     @skip_if_server_version_lt("7.9.0")
[  189s]     async def test_add_elem_no_quant(d_client):
[  189s]         float_array = [1, 4.32, 0.11, 0.5, 0.9]
[  189s]         resp = await d_client.vset().vadd(
[  189s]             "myset",
[  189s]             vector=float_array,
[  189s]             element="elem1",
[  189s]             quantization=QuantizationOptions.NOQUANT,
[  189s]         )
[  189s]         assert resp == 1
[  189s]     
[  189s]         emb = await d_client.vset().vemb("myset", "elem1")
[  189s] >       assert _validate_quantization(float_array, emb, tolerance=0.0)
[  189s] E       assert False
[  189s] E        +  where False = _validate_quantization([1, 4.32, 0.11, 0.5, 0.9], [1.0000001192092896, 4.320000171661377, 0.11000000685453415, 0.5000000596046448, 0.9000000357627869], tolerance=0.0)
[  189s] 
[  189s] tests/test_asyncio/test_vsets.py:86: AssertionError
[  189s] _________________________ test_add_elem_no_quant[pool] _________________________
[  189s] 
[  189s] d_client = <redis.asyncio.client.Redis(<redis.asyncio.connection.ConnectionPool(<redis.asyncio.connection.Connection(host=localhost,port=6379,db=0)>)>)>
[  189s] 
[  189s]     @skip_if_server_version_lt("7.9.0")
[  189s]     async def test_add_elem_no_quant(d_client):
[  189s]         float_array = [1, 4.32, 0.11, 0.5, 0.9]
[  189s]         resp = await d_client.vset().vadd(
[  189s]             "myset",
[  189s]             vector=float_array,
[  189s]             element="elem1",
[  189s]             quantization=QuantizationOptions.NOQUANT,
[  189s]         )
[  189s]         assert resp == 1
[  189s]     
[  189s]         emb = await d_client.vset().vemb("myset", "elem1")
[  189s] >       assert _validate_quantization(float_array, emb, tolerance=0.0)
[  189s] E       assert False
[  189s] E        +  where False = _validate_quantization([1, 4.32, 0.11, 0.5, 0.9], [1.0000001192092896, 4.320000171661377, 0.11000000685453415, 0.5000000596046448, 0.9000000357627869], tolerance=0.0)
[  189s] 
[  189s] tests/test_asyncio/test_vsets.py:86: AssertionError
[  189s] ____________________________ test_add_elem_no_quant ____________________________
[  189s] 
[  189s] d_client = <redis.client.Redis(<redis.connection.ConnectionPool(<redis.connection.Connection(host=localhost,port=6379,db=0)>)>)>
[  189s] 
[  189s]     @skip_if_server_version_lt("7.9.0")
[  189s]     def test_add_elem_no_quant(d_client):
[  189s]         float_array = [1, 4.32, 0.11, 0.5, 0.9]
[  189s]         resp = d_client.vset().vadd(
[  189s]             "myset",
[  189s]             vector=float_array,
[  189s]             element="elem1",
[  189s]             quantization=QuantizationOptions.NOQUANT,
[  189s]         )
[  189s]         assert resp == 1
[  189s]     
[  189s]         emb = d_client.vset().vemb("myset", "elem1")
[  189s] >       assert _validate_quantization(float_array, emb, tolerance=0.0)
[  189s] E       assert False
[  189s] E        +  where False = _validate_quantization([1, 4.32, 0.11, 0.5, 0.9], [1.0000001192092896, 4.320000171661377, 0.11000000685453415, 0.5000000596046448, 0.9000000357627869], tolerance=0.0)
[  189s] 
[  189s] tests/test_vsets.py:90: AssertionError
[  189s] =============================== warnings summary ===============================
[  189s] tests/test_asyncio/test_connection_pool.py::TestConnection::test_busy_loading_from_pipeline[single]
[  189s] tests/test_asyncio/test_connection_pool.py::TestConnection::test_busy_loading_from_pipeline[single]
[  189s]   /home/abuild/rpmbuild/BUILD/python-redis-test-6.2.0-build/redis-6.2.0/redis/asyncio/client.py:612: ResourceWarning: Unclosed client session <redis.asyncio.client.Pipeline(<redis.asyncio.connection.ConnectionPool(<redis.asyncio.connection.Connection(host=localhost,port=6379,db=0)>)>)>
[  189s]     _warn(f"Unclosed client session {self!r}", ResourceWarning, source=self)
[  189s]   Enable tracemalloc to get traceback where the object was allocated.
[  189s]   See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.
[  189s] 
[  189s] tests/test_asyncio/test_sentinel.py::test_repr_correctly_represents_connection_object
[  189s]   /home/abuild/rpmbuild/BUILD/python-redis-test-6.2.0-build/redis-6.2.0/redis/asyncio/connection.py:232: ResourceWarning: unclosed Connection <redis.asyncio.sentinel.SentinelManagedConnection,host=127.0.0.1,port=6379)>
[  189s]     _warnings.warn(
[  189s]   Enable tracemalloc to get traceback where the object was allocated.
[  189s]   See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.
[  189s] 
[  189s] -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
[  189s] =========================== short test summary info ============================
[  189s] FAILED tests/test_asyncio/test_vsets.py::test_add_elem_no_quant[single] - ass...
[  189s] FAILED tests/test_asyncio/test_vsets.py::test_add_elem_no_quant[pool] - asser...
[  189s] FAILED tests/test_vsets.py::test_add_elem_no_quant - assert False
[  189s] = 3 failed, 1161 passed, 51 skipped, 665 deselected, 22 xpassed, 3 warnings in 164.14s (0:02:44) =

What could be the cause of this and how can it be fixed?

python-redis.spec.txt
python-redis-i586.log.txt
python-redis-x86_64.log.txt

[petyaslavova]

Hi @13ilya, these test failures in openSUSE on i586 (32-bit architecture) are very likely caused by floating-point precision differences, which are more prominent or behave differently on 32-bit systems compared to 64-bit ones.

The issue arises from the use of tolerance=0.0 in three specific tests. This zero-tolerance setting is applied in cases of:

• binary quantization, where the expected output consists of exact 0s and 1s,

• and no quantization, where values are expected to remain unchanged.

Since these tests had not previously been executed on 32-bit architectures, the platform-specific floating-point precision issues were not encountered earlier.

A practical workaround is to relax the tolerance threshold slightly — setting it to something like 0.00001 (i.e., 1e-5) should be sufficient to account for minor float discrepancies while preserving test integrity.

[13ilya]

Thank you it's work.

diff -Pdpru redis-py-6.2.0.orig/tests/test_asyncio/test_vsets.py redis-py-6.2.0/tests/test_asyncio/test_vsets.py
--- redis-py-6.2.0.orig/tests/test_asyncio/test_vsets.py	2025-05-27 19:21:45.000000000 +0300
+++ redis-py-6.2.0/tests/test_asyncio/test_vsets.py	2025-06-30 18:35:24.108629200 +0300
@@ -83,7 +83,7 @@ async def test_add_elem_no_quant(d_clien
     assert resp == 1
 
     emb = await d_client.vset().vemb("myset", "elem1")
-    assert _validate_quantization(float_array, emb, tolerance=0.0)
+    assert _validate_quantization(float_array, emb, tolerance=0.00001)
 
 
 @skip_if_server_version_lt("7.9.0")
diff -Pdpru redis-py-6.2.0.orig/tests/test_vsets.py redis-py-6.2.0/tests/test_vsets.py
--- redis-py-6.2.0.orig/tests/test_vsets.py	2025-05-27 19:21:45.000000000 +0300
+++ redis-py-6.2.0/tests/test_vsets.py	2025-06-30 18:35:03.140295444 +0300
@@ -87,7 +87,7 @@ def test_add_elem_no_quant(d_client):
     assert resp == 1
 
     emb = d_client.vset().vemb("myset", "elem1")
-    assert _validate_quantization(float_array, emb, tolerance=0.0)
+    assert _validate_quantization(float_array, emb, tolerance=0.00001)
 
 
 @skip_if_server_version_lt("7.9.0")