Fix null or empty input string in COM_LoadFile (FS_Open with input empty string "" will succeed on some POSIX systems)

s1lentq · s1lentq · commit be0e1c843be9 · 2022-05-25T18:39:14.000+07:00
Resolved #919
diff --git a/rehlds/engine/common.cpp b/rehlds/engine/common.cpp
@@ -1995,6 +1995,9 @@ int EXT_FUNC COM_FileSize(const char *filename)
 
 unsigned char* EXT_FUNC COM_LoadFile(const char *path, int usehunk, int *pLength)
 {
+	if (!path || !path[0])
+		return NULL;
+
 	char base[MAX_PATH];
 	unsigned char *buf = NULL;
 

Original file line number	Diff line number	Diff line change
`@@ -1995,6 +1995,9 @@ int EXT_FUNC COM_FileSize(const char *filename)`
`1995`	`1995`
`1996`	`1996`	`unsigned char* EXT_FUNC COM_LoadFile(const char path, int usehunk, int pLength)`
`1997`	`1997`	`{`
	`1998`	`+ if (!path \|\| !path[0])`
	`1999`	`+ return NULL;`
	`2000`	`+`
`1998`	`2001`	`char base[MAX_PATH];`
`1999`	`2002`	`unsigned char *buf = NULL;`
`2000`	`2003`