Skip to content

Take promise timeout into account on retries #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dfarr opened this issue Apr 30, 2025 · 0 comments · Fixed by #247
Closed

Take promise timeout into account on retries #217

dfarr opened this issue Apr 30, 2025 · 0 comments · Fixed by #247
Assignees
@Tomperez98
Labels
enhancement New feature or request

Comments

@dfarr
Copy link
Member

dfarr commented Apr 30, 2025

If the current_time + delay > promise.timeout we should short circuit the retry policy and immediately reject the promise. The tricky part of this will be looking at the clock in a dst safe way in the scheduler.
@dfarr dfarr added the enhancement New feature or request label Apr 30, 2025
@Tomperez98 Tomperez98 self-assigned this May 9, 2025
@Tomperez98 Tomperez98 linked a pull request May 9, 2025 that will close this issue
If delay + now exceeds promise timeout. Shortcut #247
Merged
@Tomperez98 Tomperez98 moved this to In progress in Resonate Engineering May 9, 2025
@github-project-automation github-project-automation bot moved this from In progress to Done in Resonate Engineering May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tomperez98 Tomperez98

Labels
enhancement New feature or request
Projects
Resonate Engineering
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

If delay + now exceeds promise timeout. Shortcut resonatehq/resonate-sdk-py
2 participants
@dfarr @Tomperez98