Small CI tweaks (graphql-dotnet#1974)

Author: sungam3r

.github/workflows/publish-code.yml

@@ -7,6 +7,8 @@ on:
 
 env:
   NODE_VERSION: '10.x'   # Node 10 LTS
+  DOTNET_NOLOGO: true
+  DOTNET_CLI_TELEMETRY_OPTOUT: true
 
 jobs:
   publish:
@@ -54,16 +56,13 @@ jobs:
       - name: Install dependencies
         working-directory: src
         run: dotnet restore
-        env:
-          DOTNET_NOLOGO: true
-          DOTNET_CLI_TELEMETRY_OPTOUT: true
-      - name: Build solution (release config)
+      - name: Build solution [Release]
         working-directory: src
         run: dotnet build --no-restore -c Release -p:NoWarn=CS1591 -p:Version=$ref
-      - name: Pack solution (release config)
+      - name: Pack solution [Release]
         working-directory: src
         run: dotnet pack --no-restore -c Release -p:Version=$ref -o out
-      - name: Upload nuget packages as workflow artifacts
+      - name: Upload Nuget packages as workflow artifacts
         uses: actions/upload-artifact@v2
         with:
           name: Nuget packages
@@ -75,7 +74,7 @@ jobs:
       - name: Zip documentation
         working-directory: docs2/public
         run: zip -r ../../src/out/Documentation.zip .
-      - name: Upload nuget packages and documentation as release artifacts
+      - name: Upload Nuget packages and documentation as release artifacts
         uses: actions/github-script@v2
         with:
           github-token: ${{secrets.GITHUB_TOKEN}}

.github/workflows/test-code.yml

@@ -9,6 +9,10 @@ on:
       - src/**
       - .github/workflows/**
 
+env:
+  DOTNET_NOLOGO: true
+  DOTNET_CLI_TELEMETRY_OPTOUT: true
+
 jobs:
   test:
     strategy:
@@ -26,17 +30,14 @@ jobs:
       - name: Install dependencies
         working-directory: src
         run: dotnet restore
-        env:
-          DOTNET_NOLOGO: true
-          DOTNET_CLI_TELEMETRY_OPTOUT: true
-      - name: Build solution (release config)
+      - name: Build solution [Release]
         if: ${{ startsWith(matrix.os, 'ubuntu') }}
         working-directory: src
         run: dotnet build --no-restore -c Release -p:NoWarn=CS1591
-      - name: Build solution (debug config)
+      - name: Build solution [Debug]
         working-directory: src
         run: dotnet build --no-restore -c Debug -p:NoWarn=CS1591
-      - name: Test solution (debug config)
+      - name: Test solution [Debug]
         working-directory: src
         run: dotnet test --no-restore
 

src/GraphQL.Harness/GraphQL.Harness.csproj

@@ -2,6 +2,7 @@
 
   <PropertyGroup>
     <TargetFramework>netcoreapp3.1</TargetFramework>
+    <NoWarn>$(NoWarn);1591</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>

src/GraphQL.sln

@@ -7,7 +7,6 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = ".Solution Items", ".Solutio
 	ProjectSection(SolutionItems) = preProject
 		..\.editorconfig = ..\.editorconfig
 		..\.gitignore = ..\.gitignore
-		..\appveyor.yml = ..\appveyor.yml
 		Directory.Build.props = Directory.Build.props
 		..\README.md = ..\README.md
 		Tests.props = Tests.props