Update xml comments for data loaders, ValueConverter, misc (graphql-dotnet#2000)

Author: Shane32

src/GraphQL/Conversion/ValueConverter.cs

@@ -132,13 +132,21 @@ static ValueConverter()
             Register<char, int>(value => Convert.ToInt32(value));
         }
 
+        /// <summary>
+        /// <para>Returns an object of the specified type and whose value is equivalent to the specified object.</para>
+        /// <para>Throws a <see cref="InvalidOperationException"/> if there is no conversion registered; conversion functions may throw other exceptions</para>
+        /// </summary>
         public static T ConvertTo<T>(object value)
         {
             object v = ConvertTo(value, typeof(T));
 
             return v == null ? default : (T)v;
         }
 
+        /// <summary>
+        /// <para>Returns an object of the specified type and whose value is equivalent to the specified object.</para>
+        /// <para>Throws a <see cref="InvalidOperationException"/> if there is no conversion registered; conversion functions may throw other exceptions</para>
+        /// </summary>
         public static object ConvertTo(object value, Type targetType)
         {
             if (!TryConvertTo(value, targetType, out object result))
@@ -147,6 +155,10 @@ public static object ConvertTo(object value, Type targetType)
             return result;
         }
 
+        /// <summary>
+        /// <para>If a conversion delegate was registered, converts an object to the specified type and returns <c>true</c>; returns <c>false</c> if no conversion delegate is registered.</para>
+        /// <para>Conversion delegates may throw exceptions if the conversion was unsuccessful</para>
+        /// </summary>
         internal static bool TryConvertTo(object value, Type targetType, out object result, Type sourceType = null)
         {
             if (value == null || targetType.IsInstanceOfType(value))

src/GraphQL/DataLoader/DataLoaderContextAccessor.cs

@@ -2,10 +2,12 @@
 
 namespace GraphQL.DataLoader
 {
+    /// <inheritdoc cref="IDataLoaderContextAccessor"/>
     public class DataLoaderContextAccessor : IDataLoaderContextAccessor
     {
         private static readonly AsyncLocal<DataLoaderContext> _current = new AsyncLocal<DataLoaderContext>();
 
+        /// <inheritdoc/>
         public DataLoaderContext Context
         {
             get => _current.Value;

src/GraphQL/DataLoader/DataLoaderContextExtensions.cs

@@ -6,6 +6,9 @@
 
 namespace GraphQL.DataLoader
 {
+    /// <summary>
+    /// Provides extension methods for retrieving <see cref="IDataLoader"/> implementations via a <see cref="DataLoaderContext"/>
+    /// </summary>
     public static class DataLoaderContextExtensions
     {
         public static Func<CancellationToken, TResult> WrapNonCancellableFunc<TResult>(Func<TResult> func) => cancellationToken => func();

src/GraphQL/DataLoader/DataLoaderDocumentListener.cs

@@ -12,14 +12,19 @@ public class DataLoaderDocumentListener : IDocumentExecutionListener
     {
         private readonly IDataLoaderContextAccessor _accessor;
 
+        /// <summary>
+        /// Constructs a <see cref="DataLoaderDocumentListener"/> with the specified <see cref="IDataLoaderContextAccessor"/>
+        /// </summary>
         public DataLoaderDocumentListener(IDataLoaderContextAccessor accessor)
         {
             _accessor = accessor;
         }
 
+        /// <inheritdoc/>
         public Task AfterValidationAsync(IExecutionContext context, IValidationResult validationResult)
             => Task.CompletedTask;
 
+        /// <inheritdoc/>
         public Task BeforeExecutionAsync(IExecutionContext context)
         {
             if (_accessor.Context == null)
@@ -28,16 +33,19 @@ public Task BeforeExecutionAsync(IExecutionContext context)
             return Task.CompletedTask;
         }
 
+        /// <inheritdoc/>
         public Task BeforeExecutionAwaitedAsync(IExecutionContext context)
             => Task.CompletedTask;
 
+        /// <inheritdoc/>
         public Task AfterExecutionAsync(IExecutionContext context)
         {
             _accessor.Context = null;
 
             return Task.CompletedTask;
         }
 
+        /// <inheritdoc/>
         public Task BeforeExecutionStepAwaitedAsync(IExecutionContext context)
             => Task.CompletedTask;
     }

src/GraphQL/DataLoader/DataLoaderExtensions.cs

@@ -8,6 +8,9 @@
 
 namespace GraphQL.DataLoader
 {
+    /// <summary>
+    /// Provides extension methods useful for data loaders
+    /// </summary>
     public static class DataLoaderExtensions
     {
         /// <summary>

src/GraphQL/Execution/ErrorInfoProvider.cs

@@ -7,22 +7,32 @@
 
 namespace GraphQL.Execution
 {
+    /// <inheritdoc cref="IErrorInfoProvider"/>
     public class ErrorInfoProvider : IErrorInfoProvider
     {
         private static readonly ConcurrentDictionary<Type, string> _exceptionErrorCodes = new ConcurrentDictionary<Type, string>();
 
         private readonly ErrorInfoProviderOptions _options;
 
+        /// <summary>
+        /// Initializes an <see cref="ErrorInfoProvider"/> with a default set of <see cref="ErrorInfoProviderOptions"/>.
+        /// </summary>
         public ErrorInfoProvider()
             : this(new ErrorInfoProviderOptions())
         {
         }
 
+        /// <summary>
+        /// Initializes an <see cref="ErrorInfoProvider"/> with a specified set of <see cref="ErrorInfoProviderOptions"/>.
+        /// </summary>
         public ErrorInfoProvider(ErrorInfoProviderOptions options)
         {
             _options = options ?? throw new ArgumentNullException(nameof(options));
         }
 
+        /// <summary>
+        /// Initializes an <see cref="ErrorInfoProvider"/> with a set of <see cref="ErrorInfoProviderOptions"/> filled out by the specified delegate.
+        /// </summary>
         public ErrorInfoProvider(Action<ErrorInfoProviderOptions> optionsBuilder)
         {
             if (optionsBuilder == null)
@@ -31,6 +41,7 @@ public ErrorInfoProvider(Action<ErrorInfoProviderOptions> optionsBuilder)
             optionsBuilder(_options);
         }
 
+        /// <inheritdoc/>
         public virtual ErrorInfo GetInfo(ExecutionError executionError)
         {
             if (executionError == null)
@@ -68,6 +79,13 @@ public virtual ErrorInfo GetInfo(ExecutionError executionError)
             };
         }
 
+        /// <summary>
+        /// <para>Returns a list of error codes derived from a specified <see cref="ExecutionError"/> instance.</para>
+        /// <para>
+        /// By default, this returns the <see cref="ExecutionError.Code"/> value if set, along with
+        /// codes generated from the type of the <see cref="Exception.InnerException"/> and all their inner exceptions.
+        /// </para>
+        /// </summary>
         protected virtual IEnumerable<string> GetCodesForError(ExecutionError executionError)
         {
             // Code could be set explicitly, and not through the constructor with the exception

src/GraphQL/Execution/ExecutionError.cs

@@ -96,23 +96,44 @@ private void SetData(IDictionary dict)
         }
     }
 
+    /// <summary>
+    /// Represents a location within a document where a parsing or execution error occurred.
+    /// </summary>
     public struct ErrorLocation : IEquatable<ErrorLocation>
     {
+        /// <summary>
+        /// The line number of the document where the error occurred, where 1 is the first line.
+        /// </summary>
         public int Line { get; set; }
 
+        /// <summary>
+        /// The column number of the document where the error occurred, where 1 is the first column.
+        /// </summary>
         public int Column { get; set; }
 
+        /// <inheritdoc/>
         public bool Equals(ErrorLocation other) => Line == other.Line && Column == other.Column;
 
+        /// <inheritdoc/>
         public override bool Equals(object obj) => obj is Location loc && Equals(loc);
 
+        /// <inheritdoc/>
         public override int GetHashCode() => (Line, Column).GetHashCode();
 
+        /// <summary>
+        /// Indicates whether two <see cref="ErrorLocation"/> instances are the same.
+        /// </summary>
         public static bool operator ==(ErrorLocation left, ErrorLocation right) => left.Equals(right);
 
+        /// <summary>
+        /// Indicates whether two <see cref="ErrorLocation"/> instances are not the same.
+        /// </summary>
         public static bool operator !=(ErrorLocation left, ErrorLocation right) => !(left == right);
     }
 
+    /// <summary>
+    /// Provides extension methods for <see cref="ExecutionError"/> instances.
+    /// </summary>
     public static class ExecutionErrorExtensions
     {
         /// <summary>

src/GraphQL/Execution/ExecutionOptions.cs

@@ -43,6 +43,7 @@ public class ExecutionOptions : IProvideUserContext
         /// <summary>Validation rules to be used by the <see cref="IDocumentValidator"/>; defaults to standard list of of validation rules - see <see cref="DocumentValidator.CoreRules"/></summary>
         public IEnumerable<IValidationRule> ValidationRules { get; set; }
 
+        /// <inheritdoc/>
         public IDictionary<string, object> UserContext { get; set; } = new Dictionary<string, object>();
 
         /// <summary>