Replace some uses of read_file with read_file_2/read_file_sloppy

Some tests use read_file and inspect is_not_found_error. Leave these
tests as-is, duplicating them to also test read_file_sloppy.

This commit should not reduce test coverage.

Author: strager

test/test-file.cpp

@@ -19,6 +19,7 @@
 #include <quick-lint-js/file.h>
 #include <quick-lint-js/have.h>
 #include <quick-lint-js/pipe.h>
+#include <quick-lint-js/sloppy-result.h>
 #include <quick-lint-js/string-view.h>
 #include <quick-lint-js/temporary-directory.h>
 #include <quick-lint-js/unreachable.h>
@@ -77,18 +78,20 @@ TEST_F(test_file, read_regular_file) {
   std::string temp_file_path = this->make_temporary_directory() + "/temp.js";
   write_file(temp_file_path, u8"hello\nworld!\n");
 
-  read_file_result file_content = read_file(temp_file_path.c_str());
-  EXPECT_TRUE(file_content.ok()) << file_content.error;
-  EXPECT_EQ(file_content.content, string8_view(u8"hello\nworld!\n"));
+  sloppy_result<padded_string> file_content =
+      read_file_sloppy(temp_file_path.c_str());
+  EXPECT_TRUE(file_content.ok()) << file_content.error();
+  EXPECT_EQ(*file_content, string8_view(u8"hello\nworld!\n"));
 }
 
 TEST_F(test_file, read_empty_regular_file) {
   std::string temp_file_path = this->make_temporary_directory() + "/temp.js";
   write_file(temp_file_path, u8"");
 
-  read_file_result file_content = read_file(temp_file_path.c_str());
-  EXPECT_TRUE(file_content.ok()) << file_content.error;
-  EXPECT_EQ(file_content.content, string8_view(u8""));
+  sloppy_result<padded_string> file_content =
+      read_file_sloppy(temp_file_path.c_str());
+  EXPECT_TRUE(file_content.ok()) << file_content.error();
+  EXPECT_EQ(*file_content, string8_view(u8""));
 }
 
 TEST_F(test_file, read_non_existing_file) {
@@ -103,6 +106,18 @@ TEST_F(test_file, read_non_existing_file) {
               AnyOf(HasSubstr("No such file"), HasSubstr("cannot find")));
 }
 
+TEST_F(test_file, read_non_existing_file_sloppy_message) {
+  std::string temp_file_path =
+      this->make_temporary_directory() + "/does-not-exist.js";
+
+  sloppy_result<padded_string> file_content =
+      read_file_sloppy(temp_file_path.c_str());
+  EXPECT_FALSE(file_content.ok());
+  EXPECT_THAT(file_content.error(), HasSubstr("does-not-exist.js"));
+  EXPECT_THAT(file_content.error(),
+              AnyOf(HasSubstr("No such file"), HasSubstr("cannot find")));
+}
+
 TEST_F(test_file, read_directory) {
   std::string temp_file_path = this->make_temporary_directory();
 
@@ -118,6 +133,21 @@ TEST_F(test_file, read_directory) {
           ));
 }
 
+TEST_F(test_file, read_directory_sloppy_message) {
+  std::string temp_file_path = this->make_temporary_directory();
+
+  sloppy_result<padded_string> file_content =
+      read_file_sloppy(temp_file_path.c_str());
+  EXPECT_FALSE(file_content.ok());
+  EXPECT_THAT(file_content.error(), HasSubstr(temp_file_path));
+  EXPECT_THAT(
+      file_content.error(),
+      testing::AnyOf(
+          HasSubstr("Is a directory"),
+          HasSubstr("Access is denied")  // TODO(strager): Improve this message.
+          ));
+}
+
 #if QLJS_HAVE_MKFIFO
 TEST_F(test_file, read_fifo) {
   std::string temp_file_path = this->make_temporary_directory() + "/fifo.js";
@@ -126,9 +156,10 @@ TEST_F(test_file, read_fifo) {
   std::thread writer_thread(
       [&]() { write_file(temp_file_path, u8"hello from fifo"); });
 
-  read_file_result file_content = read_file(temp_file_path.c_str());
-  EXPECT_TRUE(file_content.ok()) << file_content.error;
-  EXPECT_EQ(file_content.content, string8_view(u8"hello from fifo"));
+  sloppy_result<padded_string> file_content =
+      read_file_sloppy(temp_file_path.c_str());
+  EXPECT_TRUE(file_content.ok()) << file_content.error();
+  EXPECT_EQ(*file_content, string8_view(u8"hello from fifo"));
 
   writer_thread.join();
 }
@@ -139,9 +170,10 @@ TEST_F(test_file, read_empty_fifo) {
 
   std::thread writer_thread([&]() { write_file(temp_file_path, u8""); });
 
-  read_file_result file_content = read_file(temp_file_path.c_str());
-  EXPECT_TRUE(file_content.ok()) << file_content.error;
-  EXPECT_EQ(file_content.content, string8_view(u8""));
+  sloppy_result<padded_string> file_content =
+      read_file_sloppy(temp_file_path.c_str());
+  EXPECT_TRUE(file_content.ok()) << file_content.error();
+  EXPECT_EQ(*file_content, string8_view(u8""));
 
   writer_thread.join();
 }
@@ -171,9 +203,10 @@ TEST_F(test_file, read_fifo_multiple_writes) {
     }
   });
 
-  read_file_result file_content = read_file(temp_file_path.c_str());
-  EXPECT_TRUE(file_content.ok()) << file_content.error;
-  EXPECT_EQ(file_content.content, string8_view(u8"hello from fifo"));
+  sloppy_result<padded_string> file_content =
+      read_file_sloppy(temp_file_path.c_str());
+  EXPECT_TRUE(file_content.ok()) << file_content.error();
+  EXPECT_EQ(*file_content, string8_view(u8"hello from fifo"));
 
   writer_thread.join();
 }
@@ -200,9 +233,10 @@ TEST_F(test_file, read_pipe_multiple_writes) {
     pipe.writer.close();
   });
 
-  read_file_result file_content = read_file("<pipe>", pipe.reader.ref());
-  EXPECT_TRUE(file_content.ok()) << file_content.error;
-  EXPECT_EQ(file_content.content, string8_view(u8"hello from fifo"));
+  sloppy_result<padded_string> file_content =
+      read_file_sloppy("<pipe>", pipe.reader.ref());
+  EXPECT_TRUE(file_content.ok()) << file_content.error();
+  EXPECT_EQ(*file_content, string8_view(u8"hello from fifo"));
 
   writer_thread.join();
 }
@@ -233,9 +267,10 @@ TEST_F(test_file, read_pipe_empty_writes) {
     pipe.writer.close();
   });
 
-  read_file_result file_content = read_file("<pipe>", pipe.reader.ref());
-  EXPECT_TRUE(file_content.ok()) << file_content.error;
-  EXPECT_EQ(file_content.content, string8_view(u8"helloworld"));
+  sloppy_result<padded_string> file_content =
+      read_file_sloppy("<pipe>", pipe.reader.ref());
+  EXPECT_TRUE(file_content.ok()) << file_content.error();
+  EXPECT_EQ(*file_content, string8_view(u8"helloworld"));
 
   writer_thread.join();
 }