Skip to content

Conditional Navigation and Nested Graph Example #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
IvanToplak opened this issue Apr 22, 2021 · 4 comments · Fixed by #84
Closed

Conditional Navigation and Nested Graph Example #82

IvanToplak opened this issue Apr 22, 2021 · 4 comments · Fixed by #84
Assignees

Comments

@IvanToplak
Copy link
Contributor

General idea is to add more realistic flow to this app.
My suggestion is to add:

  • Splash screen which contains rocket logo on a background,
  • Login screen with welcome message and login button which calls Firebase UI flow,
  • Nested graph representing main flow,
  • Nested graph representing auth flow.

I've noticed that activity_main.xml has CollapsingToolbarLayout which means it will be shown on every fragment, which is usually not what we want (e.g. SplashFragment, LoginFragment, PhotoFragment and MapsFragment don't need to have toolbar at all). It would be better to move CollapsingToolbarLayout to fragment_main.xml.
NestedScrollView is a parent of FragmentContainerView. Scrolling behavior is also something that should be decided per each fragment.

@IvanToplak IvanToplak self-assigned this Apr 22, 2021
@IvanToplak
Copy link
Contributor Author

@brimanning @julianfalcionelli what do you think?
I would need Rocket logo in vector graphic + the background image or Lottie animation for the splash screen. Who can provide these resources?

@brimanning
Copy link
Contributor

Yeah, that sounds good to me. It probably applies to 95% of our apps, so I'd say go for it. Here's an SVG logo for you, hopefully it converts to a vector drawable easy enough.

Logo.zip

@brimanning
Copy link
Contributor

Actually, here's a better logo to use: rocketinsights_logo_mark.svg.zip.

@IvanToplak
Copy link
Contributor Author

Actually, here's a better logo to use: rocketinsights_logo_mark.svg.zip.

Nice. I can use this one with blue background.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants