Skip to content

Commit d9f8740

Browse files
committed
Tidy up potential NPEs from github comments
1 parent 4266c5d commit d9f8740

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

src/main/java/org/apache/mesos/hadoop/Utils.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
import org.apache.mesos.Protos.CommandInfo;
1313
import org.apache.mesos.Protos.ContainerInfo;
14+
import org.apache.mesos.Protos.ContainerInfo.DockerInfo;
1415
import org.apache.mesos.Protos.Parameter;
1516
import org.apache.mesos.Protos.Parameters;
1617
import org.apache.mesos.Protos.Volume;
@@ -63,25 +64,25 @@ public static CommandInfo.ContainerInfo buildContainerInfo(Configuration conf) {
6364

6465
public static ContainerInfo buildDockerContainerInfo(Configuration conf) {
6566
ContainerInfo.Builder containerInfoBuilder = ContainerInfo.newBuilder();
66-
ContainerInfo.DockerInfo.Builder dockerInfoBuilder = ContainerInfo.DockerInfo.newBuilder();
67+
DockerInfo.Builder dockerInfoBuilder = DockerInfo.newBuilder();
6768

6869
dockerInfoBuilder.setImage(conf.get("mapred.mesos.docker.image"));
6970

7071
switch (conf.getInt("mapred.mesos.docker.network", 1)) {
7172
case 1:
72-
dockerInfoBuilder.setNetwork(ContainerInfo.DockerInfo.Network.HOST);
73+
dockerInfoBuilder.setNetwork(DockerInfo.Network.HOST);
7374
case 2:
74-
dockerInfoBuilder.setNetwork(ContainerInfo.DockerInfo.Network.BRIDGE);
75+
dockerInfoBuilder.setNetwork(DockerInfo.Network.BRIDGE);
7576
case 3:
76-
dockerInfoBuilder.setNetwork(ContainerInfo.DockerInfo.Network.NONE);
77+
dockerInfoBuilder.setNetwork(DockerInfo.Network.NONE);
7778
}
7879

7980
dockerInfoBuilder.setPrivileged(conf.getBoolean("mapred.mesos.docker.privileged", false));
8081
dockerInfoBuilder.setForcePullImage(conf.getBoolean("mapred.mesos.docker.force_pull_image", false));
8182

8283
// Parse out any additional docker CLI params
8384
String[] params = conf.getStrings("mapred.mesos.docker.parameters");
84-
if (params.length > 0) {
85+
if (params != null && params.length > 0) {
8586
assert (params.length % 2) == 0; // Make sure we have an even number of parameters
8687

8788
Parameter.Builder paramBuilder = null;
@@ -99,7 +100,7 @@ public static ContainerInfo buildDockerContainerInfo(Configuration conf) {
99100

100101
// Parse out any volumes that have been defined
101102
String[] volumes = conf.getStrings("mapred.mesos.docker.volumes");
102-
if (volumes.length > 0) {
103+
if (volumes != null && volumes.length > 0) {
103104
for (int i = 0; i < volumes.length; i++) {
104105
String[] parts = volumes[i].split(":");
105106
assert parts.length > 1;

0 commit comments

Comments
 (0)