Skip to content

Commit 1d42733

Browse files
authored
Merge pull request googleapis#604 from dhermes/drop-33
Drop Python 3.3 support
2 parents f774a66 + 49d565d commit 1d42733

File tree

6 files changed

+21
-34
lines changed

6 files changed

+21
-34
lines changed

.travis.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@ matrix:
1111
env: TOX_ENV=gae
1212
- python: 2.7
1313
env: TOX_ENV=py27
14-
- python: 3.3
15-
env: TOX_ENV=py33
1614
- python: 3.4
1715
env: TOX_ENV=py34
1816
- python: 3.5

CONTRIBUTING.md

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -127,10 +127,6 @@ Running Tests
127127
least version 2.6 of `pypy` installed. See the [docs][13] for
128128
more information.
129129
130-
- **Note** that `django` related tests are turned off for Python 2.6
131-
and 3.3. This is because `django` dropped support for
132-
[2.6 in `django==1.7`][14] and for [3.3 in `django==1.9`][15].
133-
134130
Running System Tests
135131
--------------------
136132
@@ -202,7 +198,5 @@ we'll be able to accept your pull requests.
202198
[11]: #include-tests
203199
[12]: #make-the-pull-request
204200
[13]: https://oauth2client.readthedocs.io/en/latest/#using-pypy
205-
[14]: https://docs.djangoproject.com/en/1.7/faq/install/#what-python-version-can-i-use-with-django
206-
[15]: https://docs.djangoproject.com/en/1.9/faq/install/#what-python-version-can-i-use-with-django
207201
[GooglePythonStyle]: https://google.github.io/styleguide/pyguide.html
208202
[GitCommitRules]: http://chris.beams.io/posts/git-commit/#seven-rules

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ agreement.
2323
Supported Python Versions
2424
=========================
2525

26-
We support Python 2.7 and 3.3+. More information [in the docs][2].
26+
We support Python 2.7 and 3.4+. More information [in the docs][2].
2727

2828
[1]: https://github.com/google/oauth2client/blob/master/CONTRIBUTING.md
2929
[2]: https://oauth2client.readthedocs.io/#supported-python-versions

docs/index.rst

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,18 +107,24 @@ contributor license agreement.
107107
Supported Python Versions
108108
-------------------------
109109

110-
We support Python 2.7 and 3.3+. (Whatever this file says, the truth is
110+
We support Python 2.7 and 3.4+. (Whatever this file says, the truth is
111111
always represented by our `tox.ini`_).
112112

113113
.. _tox.ini: https://github.com/google/oauth2client/blob/master/tox.ini
114114

115115
We explicitly decided to support Python 3 beginning with version
116-
3.3. Reasons for this include:
116+
3.4. Reasons for this include:
117117

118118
* Encouraging use of newest versions of Python 3
119119
* Following the lead of prominent `open-source projects`_
120120
* Unicode literal support which
121121
allows for a cleaner codebase that works in both Python 2 and Python 3
122+
* Prominent projects like `django`_ have `dropped support`_ for earlier
123+
versions (3.3 support dropped in December 2015, and 2.6 support
124+
`dropped`_ in September 2014)
122125

123126
.. _open-source projects: http://docs.python-requests.org/en/latest/
124127
.. _Unicode literal support: https://www.python.org/dev/peps/pep-0414/
128+
.. _django: https://docs.djangoproject.com/
129+
.. _dropped support: https://docs.djangoproject.com/en/1.9/faq/install/#what-python-version-can-i-use-with-django
130+
.. _dropped: https://docs.djangoproject.com/en/1.7/faq/install/#what-python-version-can-i-use-with-django

setup.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@
2929
if sys.version_info < (2, 7):
3030
print('oauth2client requires python2 version >= 2.7.', file=sys.stderr)
3131
sys.exit(1)
32-
if (3, 1) <= sys.version_info < (3, 3):
33-
print('oauth2client requires python3 version >= 3.3.', file=sys.stderr)
32+
if (3, 1) <= sys.version_info < (3, 4):
33+
print('oauth2client requires python3 version >= 3.4.', file=sys.stderr)
3434
sys.exit(1)
3535

3636
install_requires = [
@@ -41,27 +41,27 @@
4141
'six>=1.6.1',
4242
]
4343

44-
long_desc = """The oauth2client is a client library for OAuth 2.0."""
44+
long_desc = 'oauth2client is a client library for OAuth 2.0.'
4545

4646
version = oauth2client.__version__
4747

4848
setup(
49-
name="oauth2client",
49+
name='oauth2client',
5050
version=version,
51-
description="OAuth 2.0 client library",
51+
description='OAuth 2.0 client library',
5252
long_description=long_desc,
53-
author="Google Inc.",
54-
url="http://github.com/google/oauth2client/",
53+
author='Google Inc.',
54+
url='http://github.com/google/oauth2client/',
5555
install_requires=install_requires,
5656
packages=find_packages(),
57-
license="Apache 2.0",
58-
keywords="google oauth 2.0 http client",
57+
license='Apache 2.0',
58+
keywords='google oauth 2.0 http client',
5959
classifiers=[
6060
'Programming Language :: Python :: 2',
6161
'Programming Language :: Python :: 2.7',
6262
'Programming Language :: Python :: 3',
63-
'Programming Language :: Python :: 3.3',
6463
'Programming Language :: Python :: 3.4',
64+
'Programming Language :: Python :: 3.5',
6565
'Development Status :: 5 - Production/Stable',
6666
'Intended Audience :: Developers',
6767
'License :: OSI Approved :: Apache Software License',

tox.ini

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[tox]
2-
envlist = py27,py33,py34,py35,pypy,gae,cover
2+
envlist = py27,py34,py35,pypy,gae,cover
33

44
[testenv]
55
basedeps = mock>=1.3.0
@@ -18,7 +18,7 @@ deps = {[testenv]basedeps}
1818
setenv =
1919
pypy: with_gmp=no
2020
DJANGO_SETTINGS_MODULE=tests.contrib.django_util.settings
21-
commands =
21+
commands =
2222
py.test {posargs}
2323

2424
[coverbase]
@@ -37,17 +37,6 @@ deps = {[testenv]deps}
3737
coverage
3838
pytest-cov
3939

40-
[testenv:py33]
41-
basepython =
42-
python3.3
43-
commands =
44-
py.test \
45-
--ignore=oauth2client/contrib/django_util \
46-
--ignore=tests/contrib/django_util \
47-
{posargs}
48-
deps = {[testenv]basedeps}
49-
keyring
50-
5140
[testenv:cover]
5241
basepython = {[coverbase]basepython}
5342
commands =

0 commit comments

Comments
 (0)