Skip to content

Source view has many scrollbars #2787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Alexendoo opened this issue Apr 5, 2025 · 5 comments · Fixed by #2796
Closed

Source view has many scrollbars #2787

Alexendoo opened this issue Apr 5, 2025 · 5 comments · Fixed by #2796
Labels
A-frontend Area: Web frontend C-bug Category: This is a bug

Comments

@Alexendoo
Copy link
Member

e.g. on https://docs.rs/crate/cargo/latest/source/Cargo.toml.orig it's gathering quite the collection

Image
@syphar syphar added C-bug Category: This is a bug A-frontend Area: Web frontend labels Apr 7, 2025
@GuillaumeGomez
Copy link
Member

I can't reproduce the bug, which browser are you using?

@GuillaumeGomez GuillaumeGomez mentioned this issue Apr 7, 2025
Merged
@Alexendoo
Copy link
Member Author

Occurs on Chrome & Firefox. If you're on Firefox Linux you may need to enable the "always show scrollbars" setting as it can default to overlay scrollbars. I would guess it's similar on macOS

@Alexendoo
Copy link
Member Author

It's from setting overflow: scroll on #source-code-container and #source-code, the actual scrolling is happening in the code element so removing these should be fine. In browsers where the scrollbar takes up room in the document (is not an overlay) scroll forces them to be visible

docs.rs/templates/style/style.scss

Lines 915 to 918 in 47a493f

#source-code-container {
display: inline-flex;
overflow: scroll;
}

docs.rs/templates/style/style.scss

Lines 943 to 946 in 47a493f

#source-code {
overflow: scroll;
width: 100%;
}

@GuillaumeGomez
Copy link
Member

Wanna send a fix then maybe? You already seem to have the solution. 😉

@Alexendoo
Copy link
Member Author

I looked at https://github.com/rust-lang/docs.rs?tab=readme-ov-file#getting-started and went with a comment instead, but actually yeah since it works in the inspector I don't need to build a local version

@Alexendoo Alexendoo mentioned this issue Apr 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-frontend Area: Web frontend C-bug Category: This is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove extra scrollbars in source view Alexendoo/docs.rs
3 participants
@syphar @Alexendoo @GuillaumeGomez