Skip to content

Version 1.5.0 should be yanked #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
carloskiki opened this issue Aug 8, 2024 · 2 comments
Closed

Version 1.5.0 should be yanked #1220

carloskiki opened this issue Aug 8, 2024 · 2 comments

Comments

@carloskiki
Copy link

Describe the bug at a high level.

criterion depends on regex = "1.5". If you have a dependency on criterion, or any crate that depends on regex = "1.5", building with -Zminimal-versions fails because regex does not build on version 1.5.0 (with some feature flag enabled). Therefore, this version should be yanked in order to make builds depending on regex = "1.5" succeed.

See CHANGELOG.md version 1.5.1.

What are the steps to reproduce the behavior?

With any crate having regex = "1.5":
1.

cargo +nightly update -Zminimal-versions
cargo build
@BurntSushi
Copy link
Member

I think the resolution here is to increase the minimal version. I don't like to yank unless there's a very compelling reason to do so.

@BurntSushi
Copy link
Member

Duplicate of #931.

@BurntSushi BurntSushi closed this as not planned Won't fix, can't repro, duplicate, stale Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants