Skip to content

Highlighting references feature should highlight unsafe ops #19467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Veykril opened this issue Mar 28, 2025 · 2 comments · May be fixed by #19687
Open

Highlighting references feature should highlight unsafe ops #19467

Veykril opened this issue Mar 28, 2025 · 2 comments · May be fixed by #19687
Assignees
@gohome001
Labels
A-ide general IDE features C-feature Category: feature request

Comments

@Veykril
Copy link
Member

Veykril commented Mar 28, 2025 •
edited by rustbot
Loading

When the cursor is on an the unsafe token of an unsafe block we should highlight all the unsafe operations within that unsafe block, similar to how we highlighting await points for asnyc blocks, loop control pointer for loops etc.
@Veykril Veykril added the C-feature Category: feature request label Mar 28, 2025
@Veykril
Copy link
Member Author

Veykril commented Mar 28, 2025 •
edited
Loading

So we want a new branch here

rust-analyzer/crates/ide/src/highlight_related.rs

Lines 79 to 101 in 11c9c4d

match token.kind() {
T![?] if config.exit_points && token.parent().and_then(ast::TryExpr::cast).is_some() => {
highlight_exit_points(sema, token).remove(&file_id)
}
T![fn] | T![return] | T![->] if config.exit_points => {
highlight_exit_points(sema, token).remove(&file_id)
}
T![await] | T![async] if config.yield_points => {
highlight_yield_points(sema, token).remove(&file_id)
}
T![for] if config.break_points && token.parent().and_then(ast::ForExpr::cast).is_some() => {
highlight_break_points(sema, token).remove(&file_id)
}
T![break] | T![loop] | T![while] | T![continue] if config.break_points => {
highlight_break_points(sema, token).remove(&file_id)
}
T![|] if config.closure_captures => highlight_closure_captures(sema, token, file_id),
T![move] if config.closure_captures => highlight_closure_captures(sema, token, file_id),
_ if config.references => {
highlight_references(sema, token, FilePosition { file_id, offset })
}
_ => None,
}
, leveraging this

rust-analyzer/crates/hir/src/semantics.rs

Line 1593 in 11c9c4d

pub fn get_unsafe_ops(&self, def: DefWithBody) -> FxHashSet<ExprOrPatSource> {
to get all relevant unsafe operations

@Veykril Veykril added the A-ide general IDE features label Mar 28, 2025
@gohome001
Copy link
Contributor

@rustbot claim

@gohome001 gohome001 linked a pull request Apr 25, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gohome001 gohome001

Labels
A-ide general IDE features C-feature Category: feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: highlight unsafe operations gohome001/rust-analyzer
2 participants
@Veykril @gohome001