./x test ui -- --help requires an additional -- when going through ./x in PowerShell (msvc)

[jieyouxu]

On Windows MSVC + PowerShell,

# Unix
$ ./x test tests/ui/ -- --n

requires an additional --

# PowerShell
$ ./x test tests/ui/ -- -- --n

Not a huge deal, just a papercut. Probably has to do with ./x.ps1 or sth treating -- as its own arg separator.

This isn't a problem if x.py is directly invoked via python, i.e.

$ python x.py -- --help

works the same on Unix / MSVC.

[ChrisDenton]

The problem is our use of the $args magic variable that will process and remove -- before the script ever sees it:

rust/x.ps1

Line 11 in 6bc57c6

$xpy_args = @($xpy) + $args

This could be fixed by passing on the raw arguments instead of using the $args magic variable. jyn514 suggested $MyInvocation could be used for this.

E.g. $MyInvocation.Statement will get the raw command line and then $MyInvocation.InvocationName can be used to replace the script path with the path to x.py.

[ChrisDenton]

Oh wait this is harder than I thought if we want to handle all edge cases. E.g. if the user does something like this:

& <# this is a comment #> "./x.p*" --help

Then parsing where the arguments gets much more complicated.

[ChrisDenton]

Ok, I don't think we can or should attempt to parse arbitrary powershell syntax. So this might need to be closed as can't fix (unless powershell provides a proper way to get the raw arguments including --).

Users can workaround it by escaping the --:

./x test tests/ui/ `-- --n

That's not ideal, admittedly.

[jieyouxu]

Yeah, it's not a big deal

[jyn514]

one possible workaround would be to use a batch file instead of powershell. but. that kinda sucks.