Skip to content

config.toml -> bootstrap.toml rename isnt mentioned in change-id warning #140185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BoxyUwU opened this issue Apr 23, 2025 · 3 comments
Closed

config.toml -> bootstrap.toml rename isnt mentioned in change-id warning #140185

BoxyUwU opened this issue Apr 23, 2025 · 3 comments
Labels
A-bootstrap-config Area: bootstrap `config.toml` and the config system T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@BoxyUwU
Copy link
Member

BoxyUwU commented Apr 23, 2025

The warning from x when change-id needs bumping tells me to go update my bootstrap.toml file, but I have no such thing ^^ I have a config.toml. Additionally the warning didn't seem to tell me that we were even renaming config.toml to bootstrap.toml so it would have been very easy to have completely missed that was happening and just updated my config.toml

@BoxyUwU BoxyUwU added C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 23, 2025
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Apr 23, 2025
@jieyouxu jieyouxu added A-bootstrap-config Area: bootstrap `config.toml` and the config system and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Apr 23, 2025
@Shourya742
Copy link
Contributor

We recently renamed config.toml to bootstrap.toml. Ideally, any changes to change-tracker should have triggered a warning to inform users about the update and prompt them to revise the changes accordingly. The logic for handling change_id updates was added after the rename, under the assumption that users would notice and adjust as needed. That said, we continue to support config.toml for backward compatibility. Perhaps we could update the warning message to mention both bootstrap.toml and config.toml, or gently encourage users to transition to bootstrap.toml moving forward ;).

@onur-ozkan onur-ozkan removed the C-bug Category: This is a bug. label May 1, 2025
@onur-ozkan
Copy link
Member

We can add a new change entry if that's what you want.

@onur-ozkan
Copy link
Member

It's there.

@onur-ozkan onur-ozkan closed this as not planned Won't fix, can't repro, duplicate, stale May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-bootstrap-config Area: bootstrap `config.toml` and the config system T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

5 participants