Skip to content

@bors try should not deny warnings #140753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lcnr opened this issue May 7, 2025 · 7 comments · Fixed by #140786
Closed

@bors try should not deny warnings #140753

lcnr opened this issue May 7, 2025 · 7 comments · Fixed by #140786
Labels
A-CI Area: Our Github Actions CI C-enhancement Category: An issue proposing an enhancement or a PR with one. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@lcnr
Copy link
Contributor

lcnr commented May 7, 2025

I've had multiple try builds fail because of an unused import. This is annoying and seems unnecessary.

We should disable deny-warnings in try builds.
@lcnr lcnr added the T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. label May 7, 2025
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label May 7, 2025
@matthiaskrgr
Copy link
Member

I think it will be very confusing when suddenly ci will fail although the try jobs passed previously, but maybe we can have something like try-job-light with a separate command?

@lcnr
Copy link
Contributor Author

lcnr commented May 7, 2025

CI already fails in a lot of cases where explicit @bors try builds succeed. Try builds do not check clippy or run UI tests.

@matthiaskrgr
Copy link
Member

ah this is about just a @bors try without any try-job: x86_64-gnu-distcheck-esque stuff 👍
makes sense then :)

@jieyouxu jieyouxu added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. A-CI Area: Our Github Actions CI and removed T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels May 7, 2025
@jieyouxu
Copy link
Member

jieyouxu commented May 7, 2025

cc @rust-lang/infra-bors

@Kobzol
Copy link
Contributor

Kobzol commented May 7, 2025

@lcnr do you want this for any custom try build (where you select the CI job executed), or only for the default try jobs that are used for perf. runs and crater?

@lcnr
Copy link
Contributor Author

lcnr commented May 7, 2025

I don't care 😅 I guess let's only do it for default try jobs and if people get annoyed by other ones, fix it then

@compiler-errors
Copy link
Member

I think default try builds could ignore warnings, since we primarily use them to generate artifacts. CI job ones are generally also used to validate things pass CI 😸

@Kobzol Kobzol mentioned this issue May 8, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue May 8, 2025
@bors
Auto merge of rust-lang#140786 - Kobzol:try-builds-no-deny-warnings, …
c7de77a 
…r=<try>

Do not deny warnings in "fast" try builds

When we do the classic ``@bors` try` build without specifying `try-job` in the PR description, we want to get a compiler toolchain for perf./crater/local experimentation as fast as possible. We don't run any tests in that case, so it seems reasonable to also ignore warnings.

Fixes: rust-lang#140753
bors added a commit to rust-lang-ci/rust that referenced this issue May 8, 2025
@bors
Auto merge of rust-lang#140786 - Kobzol:try-builds-no-deny-warnings, …
f5ff1f5 
…r=<try>

Do not deny warnings in "fast" try builds

When we do the classic ``@bors` try` build without specifying `try-job` in the PR description, we want to get a compiler toolchain for perf./crater/local experimentation as fast as possible. We don't run any tests in that case, so it seems reasonable to also ignore warnings.

Fixes: rust-lang#140753
bors added a commit to rust-lang-ci/rust that referenced this issue May 8, 2025
@bors
Auto merge of rust-lang#140786 - Kobzol:try-builds-no-deny-warnings, …
b5dfe06 
…r=<try>

Do not deny warnings in "fast" try builds

When we do the classic ``@bors` try` build without specifying `try-job` in the PR description, we want to get a compiler toolchain for perf./crater/local experimentation as fast as possible. We don't run any tests in that case, so it seems reasonable to also ignore warnings.

Fixes: rust-lang#140753
bors added a commit to rust-lang-ci/rust that referenced this issue May 8, 2025
@bors
Auto merge of rust-lang#140786 - Kobzol:try-builds-no-deny-warnings, …
7c50577 
…r=<try>

Do not deny warnings in "fast" try builds

When we do the classic ``@bors` try` build without specifying `try-job` in the PR description, we want to get a compiler toolchain for perf./crater/local experimentation as fast as possible. We don't run any tests in that case, so it seems reasonable to also ignore warnings.

Fixes: rust-lang#140753

r? `@jieyouxu`

try-job: dist-x86_64-linux
@bors bors closed this as completed in 50aa041 May 8, 2025
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this issue May 12, 2025
@bors
Auto merge of #140786 - Kobzol:try-builds-no-deny-warnings, r=jieyouxu
7403775 
Do not deny warnings in "fast" try builds

When we do the classic ``@bors` try` build without specifying `try-job` in the PR description, we want to get a compiler toolchain for perf./crater/local experimentation as fast as possible. We don't run any tests in that case, so it seems reasonable to also ignore warnings.

Fixes: rust-lang/rust#140753

r? `@jieyouxu`

try-job: dist-x86_64-linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-CI Area: Our Github Actions CI C-enhancement Category: An issue proposing an enhancement or a PR with one. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not deny warnings in "fast" try builds Kobzol/rust
6 participants
@matthiaskrgr @compiler-errors @Kobzol @lcnr @jieyouxu @rustbot