Skip to content

Test for #7663 doesn't test anything (?) #140780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pvdrz opened this issue May 8, 2025 · 0 comments
Open

Test for #7663 doesn't test anything (?) #140780

pvdrz opened this issue May 8, 2025 · 0 comments
Labels
needs-triage This issue may need triage. Remove it if it has been sufficiently triaged.

Comments

@pvdrz
Copy link
Contributor

pvdrz commented May 8, 2025

This is a similar story to #140765. Basically tests/ui/issues/issue-7663.rs doesn't test anything as the glob imports were removed from the file and there's no duplicated import for p on either case.

I think the test should no longer be run-pass and instead it should test that:

  • Importing both p items with glob imports fails
  • Importing both p items with non-glob imports fails
  • Importing one p with a glob import and another p with a non-glob import is ok.

I'll create a PR with a fix if this is correct.

Thanks!

@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage This issue may need triage. Remove it if it has been sufficiently triaged.
Projects
None yet
Development

No branches or pull requests

2 participants