Skip to content

minor improvements on running miri #140898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

minor improvements on running miri #140898

wants to merge 2 commits into from
+14 −6

Conversation

onur-ozkan
Copy link
Member

It should be clear from the commit messages when reviewing them one by one.

@rustbot
Copy link
Collaborator

rustbot commented May 10, 2025

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 10, 2025
@onur-ozkan
Copy link
Member Author

onur-ozkan commented May 10, 2025 •
edited
Loading

I assume Ralf uses this API a lot, it's worth pinging him to make sure he will be aware of this change (especially the second commit as the first one doesn't affect anything on the user side).

cc @RalfJung

@RalfJung
Copy link
Member

I have no idea what the first commit does from a user perspective. The second commit looks good, except for the comment I added. :)

@clubby789
Copy link
Contributor

Yes second commit also lgtm but I'm not sure of what the first is doing 😅

@onur-ozkan
Copy link
Member Author

Yes second commit also lgtm but I'm not sure of what the first is doing 😅

Sure. r? bootstrap

@rustbot rustbot assigned Kobzol and unassigned clubby789 May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

@jieyouxu jieyouxu jieyouxu left review comments

Assignees

@Kobzol Kobzol

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@onur-ozkan @rustbot @RalfJung @clubby789 @jieyouxu @Kobzol