Skip to content

chore: move more ui tests #140927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

chore: move more ui tests #140927

merged 1 commit into from
May 13, 2025
+36 −36

Conversation

mejrs
Copy link
Contributor

@mejrs mejrs commented May 11, 2025

@rustbot rustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 11, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
jieyouxu
jieyouxu approved these changes May 12, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you squash the commits?

@jieyouxu
Copy link
Member

One nit & commits
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 12, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 12, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@mejrs
Copy link
Contributor Author

mejrs commented May 12, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 12, 2025
@jieyouxu
Copy link
Member

Cool.
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 12, 2025

📌 Commit 60c32f6 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 12, 2025
@bors
Copy link
Collaborator

bors commented May 13, 2025

⌛ Testing commit 60c32f6 with merge 3ae0b2e...

@bors
Copy link
Collaborator

bors commented May 13, 2025

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 3ae0b2e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 13, 2025
@bors bors merged commit 3ae0b2e into rust-lang:master May 13, 2025
7 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 13, 2025
@github-actions GitHub Actions
Copy link

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 8405332 (parent) -> 3ae0b2e (this PR)

Test differences

Show 18 test diffs

Stage 1

  • [ui] tests/ui/attributes/positions/used.rs: [missing] -> pass (J0)
  • [ui] tests/ui/attributes/used-issue-126789.rs: pass -> [missing] (J0)
  • [ui] tests/ui/attributes/used/used-not-dead-code-lint.rs: [missing] -> pass (J0)
  • [ui] tests/ui/codemap_tests/utf8-bom.rs: [missing] -> pass (J0)
  • [ui] tests/ui/issues/issue-41628.rs: pass -> [missing] (J0)
  • [ui] tests/ui/rfcs/rfc-2457-non-ascii-idents/utf8_idents.rs: [missing] -> pass (J0)
  • [ui] tests/ui/used.rs: pass -> [missing] (J0)
  • [ui] tests/ui/utf8-bom.rs: pass -> [missing] (J0)
  • [ui] tests/ui/utf8_idents.rs: pass -> [missing] (J0)

Stage 2

  • [ui] tests/ui/attributes/positions/used.rs: [missing] -> pass (J1)
  • [ui] tests/ui/attributes/used-issue-126789.rs: pass -> [missing] (J1)
  • [ui] tests/ui/attributes/used/used-not-dead-code-lint.rs: [missing] -> pass (J1)
  • [ui] tests/ui/codemap_tests/utf8-bom.rs: [missing] -> pass (J1)
  • [ui] tests/ui/issues/issue-41628.rs: pass -> [missing] (J1)
  • [ui] tests/ui/rfcs/rfc-2457-non-ascii-idents/utf8_idents.rs: [missing] -> pass (J1)
  • [ui] tests/ui/used.rs: pass -> [missing] (J1)
  • [ui] tests/ui/utf8-bom.rs: pass -> [missing] (J1)
  • [ui] tests/ui/utf8_idents.rs: pass -> [missing] (J1)

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 3ae0b2e2ed34f9e3fa848379d3d47782701caa14 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-1: 5489.6s -> 11522.4s (109.9%)
  2. dist-aarch64-apple: 6077.6s -> 5226.3s (-14.0%)
  3. x86_64-apple-2: 1252.5s -> 1384.0s (10.5%)
  4. x86_64-msvc-ext3: 7548.2s -> 8202.3s (8.7%)
  5. x86_64-gnu-llvm-19-3: 7332.0s -> 6759.7s (-7.8%)
  6. i686-gnu-nopt-2: 6377.8s -> 6851.4s (7.4%)
  7. i686-msvc-1: 9357.3s -> 9931.1s (6.1%)
  8. x86_64-msvc-2: 7051.2s -> 6689.0s (-5.1%)
  9. dist-armv7-linux: 5678.4s -> 5397.4s (-4.9%)
  10. aarch64-apple: 3062.2s -> 3209.0s (4.8%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@bors bors mentioned this pull request May 13, 2025
Draft
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3ae0b2e): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 773.027s -> 771.806s (-0.16%)
Artifact size: 365.35 MiB -> 365.41 MiB (0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
A-tidy Area: The tidy tool merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.
6 participants
@mejrs @rust-log-analyzer @jieyouxu @rustbot @bors @rust-timer