code changes for refactoring ResponseReasonCode and GetValuebyIndex

code changes for refactoring ResponseReasonCode and GetValuebyIndex

Author: baluveer

Authorize.NET/AIM/Responses/GatewayResponse.cs

@@ -78,7 +78,7 @@ public string ResponseCode {
                 return ParseResponse(0);
             }
         }
-        public string ReasonResponseCode
+        public string ResponseReasonCode
         {
             get
             {

Authorize.NET/AIM/Responses/IGatewayResponse.cs

@@ -9,5 +9,7 @@ public interface IGatewayResponse {
         string ResponseCode { get; }
         string Message { get; }
         string TransactionID { get; }
+        string ResponseReasonCode { get; }
+        string GetValueByIndex(int position);
     }
 }

Authorize.NET/AIM/Responses/SIMResponse.cs

@@ -36,6 +36,12 @@ public string ResponseCode {
                 return FindKey("x_response_code");
             }
         }
+
+        public string ResponseReasonCode
+        {
+            get { throw new NotImplementedException(); }
+        }
+
         public string Message {
             get {
                 return FindKey("x_response_reason_text");
@@ -101,6 +107,21 @@ string FindKey(string key) {
             return result;
         }
 
+        public string GetValueByIndex(int position)
+        {
+            return ParseResponse(position);
+        }
+
+        internal string ParseResponse(int index)
+        {
+            var result = "";
+            if (_post.AllKeys.Count() > index)
+            {
+                result = _post[index];
+            }
+            return result;
+        }
+
         public override string ToString() {
             var sb = new StringBuilder();
             sb.AppendFormat("<li>Code = {0}", this.ResponseCode);

Authorize.NET/CP/CardPresentResponse.cs

@@ -158,6 +158,14 @@ public string ResponseCode {
             get { return ParseResponse(1); }
         }
 
+        /// <summary>
+        /// Gets the response reason code.
+        /// </summary>
+        /// <value>The response reason code.</value>
+        public string ResponseReasonCode {
+            get { return ParseResponse(2); }
+        }
+
         /// <summary>
         /// Gets the message.
         /// </summary>
@@ -174,6 +182,16 @@ public string TransactionID {
             get { return ParseResponse(7); }
         }
 
+        /// <summary>
+        /// Gets the value by index
+        /// </summary>
+        /// <param name="position">position of the response to be returned</param>
+        /// <returns>Returns index value.</returns>
+        public string GetValueByIndex(int position)
+        {
+            return ParseResponse(position);
+        }
+
         #endregion
     }
 }

AuthorizeNETtest/GatewayTest.cs

@@ -217,7 +217,7 @@ public void SendTest_FailedCredit_ReasonResponseCode()
             Assert.AreEqual(expected.Approved, actual.Approved);
             Assert.AreEqual(expected.Message, actual.Message);
             Assert.AreEqual(expected.ResponseCode, actual.ResponseCode);
-            Assert.AreEqual(((GatewayResponse)expected).ReasonResponseCode, ((GatewayResponse)expected).ReasonResponseCode);
+            Assert.AreEqual(((GatewayResponse)expected).ResponseReasonCode, ((GatewayResponse)expected).ResponseReasonCode);
 
             Assert.IsTrue(actual.TransactionID.Trim().Length > 0);
             Assert.AreEqual(expected.TransactionID, actual.TransactionID);