Skip to content

Commit 5843ef3

Browse files
committed
no_branding_update flag is no longer relevant
1 parent a42701e commit 5843ef3

File tree

3 files changed

+2
-10
lines changed

3 files changed

+2
-10
lines changed

lib/build.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -94,10 +94,7 @@ const build = (buildConfig = config.defaultBuildConfig, options) => {
9494

9595
touchOverriddenFiles()
9696
touchOverriddenVectorIconFiles()
97-
98-
if (!options.no_branding_update) {
99-
util.updateBranding()
100-
}
97+
util.updateBranding()
10198

10299
util.buildTarget()
103100
}

lib/createDist.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,7 @@ const createDist = (buildConfig = config.defaultBuildConfig, options) => {
77
config.buildConfig = buildConfig
88
config.update(options)
99

10-
if (!options.no_branding_update) {
11-
util.updateBranding()
12-
}
13-
10+
util.updateBranding()
1411
fs.removeSync(path.join(config.outputDir, 'dist'))
1512
config.buildTarget = 'create_dist'
1613
util.buildTarget()

scripts/commands.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ program
3535
.option('--official_build <official_build>', 'force official build settings')
3636
.option('--brave_google_api_key <brave_google_api_key>')
3737
.option('--brave_google_api_endpoint <brave_google_api_endpoint>')
38-
.option('--no_branding_update', 'don\'t copy BRANDING to the chrome theme dir')
3938
.option('--channel <target_chanel>', 'target channel to build', /^(beta|dev|nightly|release)$/i, 'release')
4039
.arguments('[build_config]')
4140
.action(build)
@@ -50,7 +49,6 @@ program
5049
.option('--official_build <official_build>', 'force official build settings')
5150
.option('--brave_google_api_key <brave_google_api_key>')
5251
.option('--brave_google_api_endpoint <brave_google_api_endpoint>')
53-
.option('--no_branding_update', 'don\'t copy BRANDING to the chrome theme dir')
5452
.option('--channel <target_chanel>', 'target channel to build', /^(beta|dev|nightly|release)$/i, 'release')
5553
.arguments('[build_config]')
5654
.action(createDist)

0 commit comments

Comments
 (0)