Fixing httpOnly cookies in HtmlUnit driver

barancev · barancev · commit cf812cd5ac02 · 2016-02-05T12:50:05.000+03:00
diff --git a/java/client/src/org/openqa/selenium/htmlunit/HtmlUnitDriver.java b/java/client/src/org/openqa/selenium/htmlunit/HtmlUnitDriver.java
@@ -1592,6 +1592,7 @@ public org.openqa.selenium.Cookie apply(com.gargoylesoftware.htmlunit.util.Cooki
                 .path(c.getPath())
                 .expiresOn(c.getExpires())
                 .isSecure(c.isSecure())
+                .isHttpOnly(c.isHttpOnly())
                 .build();
           }
         };
diff --git a/java/client/test/org/openqa/selenium/CookieImplementationTest.java b/java/client/test/org/openqa/selenium/CookieImplementationTest.java
@@ -436,7 +436,7 @@ public void canHandleHttpOnlyCookie() {
     assertNotNull(retrieved);
   }
 
-  @Ignore(SAFARI)
+  @Ignore({CHROME, SAFARI})
   @Test
   public void testRetainsHttpOnlyFlag() {
     Cookie addedCookie =

Original file line number	Diff line number	Diff line change
`@@ -1592,6 +1592,7 @@ public org.openqa.selenium.Cookie apply(com.gargoylesoftware.htmlunit.util.Cooki`
`1592`	`1592`	`.path(c.getPath())`
`1593`	`1593`	`.expiresOn(c.getExpires())`
`1594`	`1594`	`.isSecure(c.isSecure())`
	`1595`	`+ .isHttpOnly(c.isHttpOnly())`
`1595`	`1596`	`.build();`
`1596`	`1597`	`}`
`1597`	`1598`	`};`
Original file line number	Diff line number	Diff line change
`@@ -436,7 +436,7 @@ public void canHandleHttpOnlyCookie() {`
`436`	`436`	`assertNotNull(retrieved);`
`437`	`437`	`}`
`438`	`438`
`439`		`- @Ignore(SAFARI)`
	`439`	`+ @Ignore({CHROME, SAFARI})`
`440`	`440`	`@Test`
`441`	`441`	`public void testRetainsHttpOnlyFlag() {`
`442`	`442`	`Cookie addedCookie =`